New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Use the correct DIPY logo as the banner in `README`. #1464

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
3 participants
@jhlegarreta
Contributor

jhlegarreta commented Mar 15, 2018

Use the correct DIPY logo as the banner for the GitHub README file.

Fixes #1462.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 15, 2018

Codecov Report

Merging #1464 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
- Coverage    87.5%   87.49%   -0.02%     
==========================================
  Files         241      241              
  Lines       30789    30789              
  Branches     3322     3322              
==========================================
- Hits        26942    26938       -4     
- Misses       3071     3074       +3     
- Partials      776      777       +1
Impacted Files Coverage Δ
dipy/reconst/forecast.py 90.15% <0%> (-2.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d856062...ac22727. Read the comment docs.

README.rst Outdated
@@ -1,4 +1,4 @@
.. image:: doc/_static/dipy-banner.png
.. image:: https://elef.soic.indiana.edu/dipy/static/images/dipy-logo.png

This comment has been minimized.

@Garyfallidis

Garyfallidis Mar 16, 2018

Member

Hi Jon. Do not add this link there. This website is temporary. I sent you the png in an email. You can either put the png in a public space like figshare. Or reduce its size (if needed) and add it in doc/_static/dipy-logo.png
If you go with the second option make sure the png is not larger than 200KBytes.

This comment has been minimized.

@jhlegarreta

jhlegarreta Mar 16, 2018

Contributor

Done in commit ac22727.

Jon Haitz Legarreta
DOC: Use the correct DIPY logo as the banner in `README`.
Use the correct DIPY logo as the banner for the GitHub `README` file.

Fixes #1462.

@jhlegarreta jhlegarreta force-pushed the jhlegarreta:UseCorrectDIPYLogoInBannerInREADME branch from 069efc0 to ac22727 Mar 16, 2018

@Garyfallidis Garyfallidis merged commit bd36ecc into nipy:master Mar 16, 2018

2 of 3 checks passed

codecov/project 87.49% (-0.02%) compared to d856062
Details
codecov/patch Coverage not affected when comparing d856062...ac22727
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1464 from jhlegarreta/UseCorrectDIPYLogoInBan…
…nerInREADME

DOC: Use the correct DIPY logo as the banner in `README`.

@jhlegarreta jhlegarreta deleted the jhlegarreta:UseCorrectDIPYLogoInBannerInREADME branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment