New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: correct error when doing 'make html' #1468

Merged
merged 6 commits into from Apr 4, 2018

Conversation

Projects
None yet
3 participants
@RicciWoo
Contributor

RicciWoo commented Mar 19, 2018

This PR is to correct the error when doing 'make html':
ValueError: The section Notes appears twice in the docstring of None in None.
With the help of @skoudoro & @Garyfallidis, we find the bug and fix it.

RicciWoo added some commits Mar 15, 2018

Merge pull request #1 from nipy/master
incorporate from upstream changes
Merge pull request #2 from nipy/master
incorporate updates from upstream
@codecov-io

This comment has been minimized.

codecov-io commented Mar 20, 2018

Codecov Report

Merging #1468 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1468      +/-   ##
=========================================
+ Coverage   87.49%   87.5%   +0.01%     
=========================================
  Files         241     241              
  Lines       30789   30789              
  Branches     3322    3322              
=========================================
+ Hits        26939   26943       +4     
+ Misses       3074    3071       -3     
+ Partials      776     775       -1
Impacted Files Coverage Δ
dipy/reconst/dti.py 96.5% <ø> (ø) ⬆️
dipy/reconst/forecast.py 92.22% <0%> (+2.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd36ecc...1015c59. Read the comment docs.

@RicciWoo RicciWoo changed the title from BF: Fix bug of 'make html' to [DOC] correct error when doing 'make html' Mar 20, 2018

RicciWoo added some commits Mar 20, 2018

@skoudoro

This comment has been minimized.

Member

skoudoro commented Mar 20, 2018

Hi @RicciWoo, thanks for this first contribution! I will test it and let you know.

@RicciWoo RicciWoo changed the title from [DOC] correct error when doing 'make html' to DOC: correct error when doing 'make html' Mar 23, 2018

@skoudoro skoudoro merged commit 320483a into nipy:master Apr 4, 2018

3 checks passed

codecov/patch Coverage not affected when comparing bd36ecc...1015c59
Details
codecov/project 87.5% (+0.01%) compared to bd36ecc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Member

skoudoro commented Apr 4, 2018

Everything works well, Thanks @RicciWoo, merging

@RicciWoo RicciWoo deleted the RicciWoo:fix-bug-of-make-html branch Apr 12, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1468 from RicciWoo/fix-bug-of-make-html
DOC: correct error when doing 'make html'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment