New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix typo on website & examples #1474

Merged
merged 37 commits into from Apr 13, 2018

Conversation

Projects
None yet
3 participants
@RicciWoo
Contributor

RicciWoo commented Mar 23, 2018

  1. change Dipy & dipy to DIPY on documents
  2. change some acronyms to be all capitals
  3. fix some typos and fake hyperlinks
  4. fix some makeup styles and indentations
@codecov-io

This comment has been minimized.

codecov-io commented Mar 23, 2018

Codecov Report

Merging #1474 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1474      +/-   ##
==========================================
+ Coverage   87.51%   87.51%   +<.01%     
==========================================
  Files         241      241              
  Lines       30698    30698              
  Branches     3320     3320              
==========================================
+ Hits        26865    26866       +1     
  Misses       3058     3058              
+ Partials      775      774       -1
Impacted Files Coverage Δ
dipy/reconst/shore.py 85.15% <ø> (ø) ⬆️
dipy/info.py 100% <ø> (ø) ⬆️
dipy/reconst/mapmri.py 90.28% <ø> (ø) ⬆️
dipy/reconst/dsi.py 81.31% <ø> (ø) ⬆️
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17140cd...af36b13. Read the comment docs.

RicciWoo added some commits Mar 25, 2018

Merge pull request #4 from RicciWoo/fix-bug-sfm_reconst
delete unexpected argument scale

Jon Haitz Legarreta Gorroño and others added some commits Mar 26, 2018

Jon Haitz Legarreta Gorroño
DOC: Fix typos in DSI, MAPMRI and SHORE reconstruction files.
Fix typos:
- Fix `wavector` : `wave vector`.
- Fix `porbability` : `probability`.
- Fix `eapactical` : `Practical` in reference `[4] Cheng J. et al.`.
- Fix `eapoc`: for `Proc` (short for Proceedings) in references.
Merge pull request #9 from nipy/master
incorporate upstream updates 20180409
@skoudoro

Hi @RicciWoo, Thank you for this PR. As you said, this PR is for fixing typo so you can you remove some of the change below.
Otherwise, it looks good to me. we can merge it as soon as you make this change

@@ -140,7 +140,7 @@
window.clear(ren)
fodf_peaks = actor.peak_slicer(sf_peaks.peak_dirs, sf_peaks.peak_values, scale=1.3)
fodf_peaks = actor.peak_slicer(sf_peaks.peak_dirs, sf_peaks.peak_values)

This comment has been minimized.

@skoudoro

skoudoro Apr 13, 2018

Member

This change is not typo fix, can you remove it? you already have a new PR with this change

@@ -225,7 +227,7 @@
parallel=True)
window.clear(ren)
fodf_peaks = actor.peak_slicer(csd_peaks.peak_dirs, csd_peaks.peak_values, scale=1.3)
fodf_peaks = actor.peak_slicer(csd_peaks.peak_dirs, csd_peaks.peak_values)

This comment has been minimized.

@skoudoro

skoudoro Apr 13, 2018

Member

This change is not typo fix, can you remove it? you already have a new PR with this change

@@ -151,6 +151,8 @@
"""
response_signal = response.on_sphere(sphere)
# transform our data from 1D to 4D
response_signal = response_signal[None, None, None, :]

This comment has been minimized.

@skoudoro

skoudoro Apr 13, 2018

Member

This change is not typo fix, can you remove it and create a new PR for that?

RicciWoo added some commits Apr 13, 2018

@RicciWoo

This comment has been minimized.

Contributor

RicciWoo commented Apr 13, 2018

@skoudoro, I'v already removed all changes that are not typo fix.

@skoudoro skoudoro merged commit 5cab11d into nipy:master Apr 13, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 17140cd...af36b13
Details
codecov/project 87.51% (+<.01%) compared to 17140cd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Member

skoudoro commented Apr 13, 2018

Thanks @RicciWoo, merging

@RicciWoo RicciWoo deleted the RicciWoo:fix-typo-on-website branch May 3, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment