New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor demon registration - _iterate #1475

Merged
merged 2 commits into from Mar 27, 2018

Conversation

Projects
None yet
3 participants
@Borda
Contributor

Borda commented Mar 23, 2018

related to #1470 since somehow after rebase it was automatically closed

@Borda Borda referenced this pull request Mar 23, 2018

Closed

simplify SDR iterate #1470

@Borda Borda force-pushed the Borda:refactor_reg_iter branch from 8e7ea7b to c745354 Mar 23, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Mar 23, 2018

Codecov Report

Merging #1475 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1475      +/-   ##
==========================================
+ Coverage   87.48%   87.49%   +<.01%     
==========================================
  Files         241      241              
  Lines       30805    30807       +2     
  Branches     3322     3321       -1     
==========================================
+ Hits        26951    26955       +4     
  Misses       3078     3078              
+ Partials      776      774       -2
Impacted Files Coverage Δ
dipy/align/imwarp.py 98.62% <100%> (+0.23%) ⬆️
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e01ee...c745354. Read the comment docs.

@Borda

This comment has been minimized.

Contributor

Borda commented Mar 26, 2018

@skoudoro skoudoro merged commit 99b768d into nipy:master Mar 27, 2018

3 checks passed

codecov/patch 100% of diff hit (target 87.48%)
Details
codecov/project 87.49% (+<.01%) compared to b8e01ee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Member

skoudoro commented Mar 27, 2018

LGTM, merging ! Thanks @Borda

@Borda Borda deleted the Borda:refactor_reg_iter branch Apr 12, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1475 from Borda/refactor_reg_iter
Refactor demon registration - _iterate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment