New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fix bug of no attribute 'GlobalImmediateModeRenderingOn' in actor.py #1481

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
4 participants
@RicciWoo
Contributor

RicciWoo commented Mar 26, 2018

It seems like in VTK 8, there is no long attribute 'GlobalImmediateModeRenderingOn' in vtkMapper.
This PR is just to remove it, that is comment out line 448 in actor.py:
#poly_mapper.GlobalImmediateModeRenderingOn()
This solves the problem of no attribute 'GlobalImmediateModeRenderingOn' in issue #1469.

RicciWoo added some commits Mar 15, 2018

Merge pull request #1 from nipy/master
incorporate from upstream changes
Merge pull request #2 from nipy/master
incorporate updates from upstream

@RicciWoo RicciWoo changed the title from BF: Fix bug no attribute actor to BF: Fix bug of no attribute 'GlobalImmediateModeRenderingOn' in actor.py Mar 26, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Mar 26, 2018

Codecov Report

Merging #1481 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
+ Coverage   87.48%   87.49%   +<.01%     
==========================================
  Files         241      241              
  Lines       30805    30804       -1     
  Branches     3322     3322              
==========================================
  Hits        26951    26951              
  Misses       3078     3078              
+ Partials      776      775       -1
Impacted Files Coverage Δ
dipy/reconst/dti.py 96.5% <ø> (ø) ⬆️
dipy/viz/actor.py 82.98% <ø> (-0.03%) ⬇️
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e01ee...19a716f. Read the comment docs.

@dmreagan dmreagan added this to UI PR needs a review in Viz Module Mar 27, 2018

@@ -445,7 +445,7 @@ def streamtube(lines, colors=None, opacity=1, linewidth=0.1, tube_sides=9,
poly_mapper.ScalarVisibilityOn()
poly_mapper.SetScalarModeToUsePointFieldData()
poly_mapper.SelectColorArray("Colors")
poly_mapper.GlobalImmediateModeRenderingOn()
#poly_mapper.GlobalImmediateModeRenderingOn()

This comment has been minimized.

@skoudoro

skoudoro Apr 4, 2018

Member

Hi @RicciWoo, It does not really fix the problem. It would be better to add a vtk version test here. Can you do this change? Thanks

This comment has been minimized.

@RicciWoo

RicciWoo Apr 4, 2018

Contributor

I would like to try, but I don't know how to add a test, can you give me some hint?

This comment has been minimized.

@RicciWoo

RicciWoo Apr 5, 2018

Contributor

it's related to issue #1490

@dmreagan

This comment has been minimized.

Contributor

dmreagan commented Apr 5, 2018

Replacing with #1493

@dmreagan dmreagan closed this Apr 5, 2018

@RicciWoo RicciWoo deleted the RicciWoo:fix-bug-no-attribute-actor branch Apr 12, 2018

@dmreagan dmreagan moved this from UI PR needs a review to Done in Viz Module Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment