New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Use the correct punctuation marks for `et al.`. #1484

Merged
merged 1 commit into from Mar 27, 2018

Conversation

Projects
None yet
3 participants
@jhlegarreta
Contributor

jhlegarreta commented Mar 26, 2018

Change et. al for et al..

Jon Haitz Legarreta Gorroño
DOC: Use the correct punctuation marks for `et al.`.
Change `et. al` for `et al.`.
@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Mar 27, 2018

The reported error

FAIL: dipy.reconst.tests.test_dki_micro.test_single_fiber_model
Arrays are not almost equal to 7 decimals

for Python 3.4 is unrelated to the changes introduced in this topic. Only documentation has been changed. @arokem @skoudoro I'd dare to say that this is ready to be merged.

@arokem

This comment has been minimized.

Member

arokem commented Mar 27, 2018

Yep. Let's see if it persists when I merge this on master. We might have to deal with this on a separate issue.

@arokem arokem merged commit 6ee882e into nipy:master Mar 27, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@codecov-io

This comment has been minimized.

codecov-io commented Mar 27, 2018

Codecov Report

Merging #1484 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1484   +/-   ##
=======================================
  Coverage   87.49%   87.49%           
=======================================
  Files         241      241           
  Lines       30805    30805           
  Branches     3322     3322           
=======================================
  Hits        26952    26952           
  Misses       3078     3078           
  Partials      775      775
Impacted Files Coverage Δ
dipy/reconst/gqi.py 54.54% <ø> (ø) ⬆️
dipy/workflows/reconst.py 81.31% <ø> (ø) ⬆️
dipy/reconst/shm.py 86.64% <ø> (ø) ⬆️
dipy/reconst/shore.py 85.15% <ø> (ø) ⬆️
dipy/reconst/mapmri.py 90.07% <ø> (ø) ⬆️
dipy/reconst/forecast.py 92.22% <ø> (ø) ⬆️
dipy/reconst/dsi.py 81.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53dbd0e...80b16ad. Read the comment docs.

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1484 from jhlegarreta/FixEtAlPunctuationInRef…
…erences

DOC: Use the correct punctuation marks for `et al.`.

@jhlegarreta jhlegarreta deleted the jhlegarreta:FixEtAlPunctuationInReferences branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment