New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parichit dipy flows #1486

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@parichit
Copy link
Contributor

parichit commented Mar 27, 2018

Created a basic DIPY workflow to probe the status of the files in the system. Tested the behavior on the local system to identify bugs and performance.

Parichit Sharma and others added some commits Mar 27, 2018

Parichit Sharma
Stable commit of the first basic DIPY workflow
Details:
1) Created a basic workflow inspired from the example given on the DIPY workflows page:
URL: http://nipy.org/dipy/examples_built/workflow_creation.html#example-workflow-creation

2) Enabled the basic input handling in the workflow script.

3) Tested the script on the local machine it works as expected.

4) Future work: Will addthe feature for handling the directory path dynamically too.
Currently, the script only checks for the existense of files in the 'scratch/very_scratch'
directory of the dipy istallation.
Parichit Sharma
Modified the check_scratch to correct the description.
1) Only the files is checked for existense.
2) The support for specifying the directory is still not implemented in the script.
3) The comments and the description in the test script has been updated to reflect this.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 27, 2018

Codecov Report

Merging #1486 into master will decrease coverage by 8.92%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1486      +/-   ##
==========================================
- Coverage   87.48%   78.56%   -8.93%     
==========================================
  Files         241      242       +1     
  Lines       30807    30817      +10     
  Branches     3321     3324       +3     
==========================================
- Hits        26951    24210    -2741     
- Misses       3081     5984    +2903     
+ Partials      775      623     -152
Impacted Files Coverage Δ
dipy/workflows/check_scratch.py 46.15% <46.15%> (ø)
dipy/viz/tests/test_window.py 12% <0%> (-81.6%) ⬇️
dipy/viz/widget.py 6.71% <0%> (-81.35%) ⬇️
dipy/viz/interactor.py 19.37% <0%> (-78.75%) ⬇️
dipy/viz/actor.py 4.55% <0%> (-78.46%) ⬇️
dipy/viz/tests/test_interactor.py 18.18% <0%> (-71.6%) ⬇️
dipy/viz/ui.py 18.44% <0%> (-70.86%) ⬇️
dipy/viz/tests/test_ui.py 16.61% <0%> (-68.82%) ⬇️
dipy/viz/colormap.py 17.85% <0%> (-68.58%) ⬇️
dipy/viz/tests/test_actors.py 8.91% <0%> (-64.76%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b768d...15cb39d. Read the comment docs.

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Mar 27, 2018

hi @parichit, thanks for this contribution!

I do not think this workflow is necessary but I think you should update all the current workflows with your test.
I recommend you to close this PR and create a new one with this update.
There is a lot of pep8 (comma, space, ...) issue in your code so I recommend you to have a look at python coding style

@parichit

This comment has been minimized.

Copy link
Contributor

parichit commented May 30, 2018

Closing this PR due to redundant workflow.

@parichit parichit closed this May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment