New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit for updated check_scratch.py script. #1487

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@parichit
Copy link
Contributor

parichit commented Mar 27, 2018

  1. Not the ascript accpets a directory path and list all the contents in that specified directory.
  2. Don't understand why the script still throws errors when the condition fails, it should
    just execute the else block.
Parichit Sharma
Commit for updated check_scratch.py script.
1) Not the ascript accpets a directory path and list all the contents in that specified directory.
2) Don't understand why the script still throws errors when the condition fails, it should
just execute the else block.
@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Mar 27, 2018

same comment as #1486
I do not think this workflow is necessary but I think you should update all the current workflows with your test.
I recommend you to close this PR and create a new one with this update.
There is a lot of pep8 (comma, space, ...) issue in your code so I recommend you to have a look at python coding style
Do not forget to add some tests

@parichit

This comment has been minimized.

Copy link
Contributor

parichit commented Mar 27, 2018

@parichit

This comment has been minimized.

Copy link
Contributor

parichit commented May 30, 2018

The test in this workflow script is not versatile enough to handle all the input cases.

Closing this PR and will open a new PR for different test cases.

@parichit parichit closed this May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment