Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Commit for updated check_scratch.py script. #1487
same comment as #1486
Hey Serge, Thanks so much for responding. I will close this PR and apply to all other workflows. Only thing I don't understand is that my edotor is PEP8 compliant and it does not show any errors with respect to code formatting. But I will try couple of other editors and see if there are any issues in the formatting. Thanks so much :)…
On Tue, Mar 27, 2018, 5:15 PM Serge Koudoro ***@***.***> wrote: same comment as #1486 <#1486> I do not think this workflow is necessary but I think you should update all the current workflows with your test. I recommend you to close this PR and create a new one with this update. There is a lot of pep8 (comma, space, ...) issue in your code so I recommend you to have a look at python coding style <https://www.python.org/dev/peps/pep-0008/> Do not forget to add some tests — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1487 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALc4Iq_Lc9apESlsn4otRczibhXWlKRNks5tiqwLgaJpZM4S8a6y> .