Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Enh ui components positioning (with code refactoring) #1492
Changes similar to #1441
requested review from
and removed request for
Apr 5, 2018
@@ Coverage Diff @@ ## master #1492 +/- ## ========================================== - Coverage 87.55% 87.48% -0.08% ========================================== Files 246 242 -4 Lines 31370 30648 -722 Branches 3434 3300 -134 ========================================== - Hits 27467 26812 -655 + Misses 3085 3068 -17 + Partials 818 768 -50
Apr 5, 2018
changed the title
Enh ui components positioning (with code refactoring and documentation)
Apr 7, 2018
@dmreagan @ranveeraggarwal I'm not planning on making any more modification. I think this PR clean a lot of the UI code we had and centralized a bunch of functionalities (e.g.
It also shows how event callbacks should be set and used (e.g.
Lastly, it favors the use of simpler UI components to build more complicated one (e.g.
@MarcCote you have removed the FileSelectMenu2D that means that after this is merged we will have to merge the ListBox2D fast otherwise people will not have this functionality in master. And possibly keep both names too.
I only have a few comments. Please make the corrections and will merge asap to facilitate the GSoC projects.
@MarcCote can you look at this error? https://travis-ci.org/nipy/dipy/jobs/385383361#L5024