New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix surface rendering bugs in VTK8 #1493

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
4 participants
@dmreagan
Contributor

dmreagan commented Apr 5, 2018

Update some defaults and remove a deprecated feature for the new OpenGL2 rendering backend in VTK7+.

Also removed an unused light parameter that is missing from the doc string.

This PR fixes #1490 and replaces #1481.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 5, 2018

Codecov Report

Merging #1493 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1493      +/-   ##
==========================================
- Coverage   87.49%   87.48%   -0.01%     
==========================================
  Files         241      241              
  Lines       30807    30810       +3     
  Branches     3321     3324       +3     
==========================================
  Hits        26954    26954              
- Misses       3078     3079       +1     
- Partials      775      777       +2
Impacted Files Coverage Δ
dipy/viz/utils.py 55.68% <20%> (-0.34%) ⬇️
dipy/viz/actor.py 82.72% <71.42%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ca2ae...ab37dd7. Read the comment docs.

@MarcCote

LGTM

@dmreagan dmreagan added this to UI PR needs a review in Viz Module Apr 11, 2018

@skoudoro

This comment has been minimized.

Member

skoudoro commented Apr 13, 2018

Thank you @dmreagan merging!

@skoudoro skoudoro merged commit 69b500c into nipy:master Apr 13, 2018

1 of 3 checks passed

codecov/patch 50% of diff hit (target 87.49%)
Details
codecov/project 87.48% (-0.01%) compared to 52ca2ae
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Viz Module automation moved this from UI PR needs a review to Done Apr 13, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1493 from dmreagan/iss1490
Fix surface rendering bugs in VTK8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment