New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fix bug in example of reconst_csd.py #1494

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
3 participants
@RicciWoo
Contributor

RicciWoo commented Apr 11, 2018

This is to fix the bugs in example of reconst_csd.py:

File “~/dipy/dipy/viz/actor.py", line 717, in odf_slicer
    (szx, szy, szz) = odfs.shape[:3]
ValueError: not enough values to unpack (expected 3, got 1)

and

TypeError: peak_slicer() got an unexpected keyword argument ‘scale’

The modifications are:

  1. change image data 'response_signal' from 1D to 4D before calling to 'actor.odf_slicer()';
  2. reduce the parameter 'scale' to 'actor.odf_slicer()' because it's too large in 'csd_odfs.png';
  3. remove unexpected argument ‘scale' when calling 'actor.peak_slicer()'.
@codecov-io

This comment has been minimized.

codecov-io commented Apr 12, 2018

Codecov Report

Merging #1494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1494   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files         241      241           
  Lines       30698    30698           
  Branches     3320     3320           
=======================================
  Hits        26865    26865           
  Misses       3058     3058           
  Partials      775      775

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17140cd...6749008. Read the comment docs.

@skoudoro

LGTM

@skoudoro

This comment has been minimized.

Member

skoudoro commented Apr 13, 2018

Thanks @RicciWoo

@skoudoro skoudoro merged commit 8c3edf9 into nipy:master Apr 13, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 17140cd...6749008
Details
codecov/project 87.51% remains the same compared to 17140cd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RicciWoo RicciWoo deleted the RicciWoo:bf-ex-reconst_csd branch May 3, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1494 from RicciWoo/bf-ex-reconst_csd
BF: fix bug in example of reconst_csd.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment