New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fix bug in example of sfm_reconst.py #1495

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
3 participants
@RicciWoo
Contributor

RicciWoo commented Apr 12, 2018

This is to fix the bug in example of sfm_reconst.py:

TypeError: peak_slicer() got an unexpected keyword argument ‘scale’

The modifications are:

  1. reduce the parameter 'scale' to 'actor.odf_slicer()' because it's too large in 'sf_both.png';
  2. remove unexpected argument ‘scale' when calling 'actor.peak_slicer()'.
@codecov-io

This comment has been minimized.

codecov-io commented Apr 12, 2018

Codecov Report

Merging #1495 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1495      +/-   ##
=========================================
- Coverage   87.51%   87.5%   -0.01%     
=========================================
  Files         241     241              
  Lines       30698   30698              
  Branches     3320    3320              
=========================================
- Hits        26865   26862       -3     
- Misses       3058    3061       +3     
  Partials      775     775
Impacted Files Coverage Δ
dipy/reconst/forecast.py 90.15% <0%> (-2.08%) ⬇️
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17140cd...25ca649. Read the comment docs.

@skoudoro

LGTM

@skoudoro

This comment has been minimized.

Member

skoudoro commented Apr 13, 2018

Thanks @RicciWoo

@skoudoro skoudoro merged commit 15306f4 into nipy:master Apr 13, 2018

2 of 3 checks passed

codecov/project 87.5% (-0.01%) compared to 17140cd
Details
codecov/patch Coverage not affected when comparing 17140cd...25ca649
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RicciWoo RicciWoo deleted the RicciWoo:bf-ex-sfm_reconst branch May 3, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1495 from RicciWoo/bf-ex-sfm_reconst
BF: fix bug in example of sfm_reconst.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment