New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fix bug in example of fiber_to_bundle_coherence.py #1497

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
3 participants
@RicciWoo
Contributor

RicciWoo commented Apr 12, 2018

The last modification of fiber_to_bundle_coherence.py make this error:

File "~/dipy/dipy/tracking/streamline.py", line 150, in <listcomp>
    n_elements = np.sum([len(e) for e in elements])
TypeError: object of type 'numpy.bool_' has no len()

So to fix the bug, I just changed back to where it was.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 12, 2018

Codecov Report

Merging #1497 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
+ Coverage   87.51%   87.51%   +<.01%     
==========================================
  Files         241      241              
  Lines       30698    30698              
  Branches     3320     3320              
==========================================
+ Hits        26865    26866       +1     
  Misses       3058     3058              
+ Partials      775      774       -1
Impacted Files Coverage Δ
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17140cd...e7b864b. Read the comment docs.

@skoudoro skoudoro merged commit fd0cb15 into nipy:master Apr 13, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 17140cd...e7b864b
Details
codecov/project 87.51% (+<.01%) compared to 17140cd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RicciWoo RicciWoo deleted the RicciWoo:bf-ex-fiber_to_bundle_coherence branch May 3, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1497 from RicciWoo/bf-ex-fiber_to_bundle_cohe…
…rence

BF: fix bug in example of fiber_to_bundle_coherence.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment