New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fix bug in example of segment_quickbundles.py #1498

Merged
merged 1 commit into from Apr 29, 2018

Conversation

Projects
None yet
3 participants
@RicciWoo
Contributor

RicciWoo commented Apr 12, 2018

The last modification of segment_quickbundles.py makes this error:

File "dipy/segment/clustering_algorithms.pyx", line 108, in 
dipy.segment.clustering_algorithms.quickbundles
ValueError: setting an array element with a sequence.

So to fix the bug, I just changed back to where it was.
Then it turns to the attribute error of VTK 8.1:

"~/dipy/dipy/viz/actor.py", line 448, in streamtube
poly_mapper.GlobalImmediateModeRenderingOn()
AttributeError: 'vtkRenderingOpenGL2Python.vtkOpenGLPolyDataMapper' object 
has no attribute 'GlobalImmediateModeRenderingOn'

And I checked that the PR #1493 solves this problem. The resulting pictures look good.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 12, 2018

Codecov Report

Merging #1498 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
+ Coverage   87.51%   87.51%   +<.01%     
==========================================
  Files         241      241              
  Lines       30698    30698              
  Branches     3320     3320              
==========================================
+ Hits        26865    26866       +1     
  Misses       3058     3058              
+ Partials      775      774       -1
Impacted Files Coverage Δ
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17140cd...6641cec. Read the comment docs.

@MarcCote MarcCote requested a review from skoudoro Apr 13, 2018

@skoudoro

This comment has been minimized.

Member

skoudoro commented Apr 29, 2018

For the moment, I will merge that one but we need to update 'fornix' dataset. Thank you @RicciWoo

@skoudoro skoudoro merged commit ab4c4bc into nipy:master Apr 29, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 17140cd...6641cec
Details
codecov/project 87.51% (+<.01%) compared to 17140cd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RicciWoo RicciWoo deleted the RicciWoo:bf-ex-segment_quickbundles branch May 3, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1498 from RicciWoo/bf-ex-segment_quickbundles
BF: fix bug in example of segment_quickbundles.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment