New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_whole_brain_slr precision #1504

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
3 participants
@skoudoro
Member

skoudoro commented Apr 30, 2018

fix tests precision for test_whole_brain_slr.
This needs to be improved in a close future

fix tests precision for test_whole_brain_slr.
This needs to be improve in a close future
@codecov-io

This comment has been minimized.

codecov-io commented Apr 30, 2018

Codecov Report

Merging #1504 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
- Coverage   87.55%   87.55%   -0.01%     
==========================================
  Files         246      246              
  Lines       31366    31366              
  Branches     3433     3433              
==========================================
- Hits        27464    27463       -1     
  Misses       3085     3085              
- Partials      817      818       +1
Impacted Files Coverage Δ
dipy/align/tests/test_whole_brain_slr.py 93.75% <ø> (ø) ⬆️
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b420b67...b647981. Read the comment docs.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented May 1, 2018

Sound good. Thanks. Just to say here that this test had some issue on Macosx taking a bit longer time than in other PRs.

@Garyfallidis Garyfallidis merged commit 444f182 into nipy:master May 1, 2018

2 of 3 checks passed

codecov/project 87.55% (-0.01%) compared to b420b67
Details
codecov/patch Coverage not affected when comparing b420b67...b647981
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:fix-test-whole-brain branch May 1, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment