New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Use the new Streamlines API for orienting of streamlines. #1515

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
5 participants
@arokem
Copy link
Member

arokem commented May 11, 2018

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 11, 2018

Codecov Report

Merging #1515 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
+ Coverage   87.33%   87.34%   +<.01%     
==========================================
  Files         246      246              
  Lines       31804    31806       +2     
  Branches     3450     3450              
==========================================
+ Hits        27777    27780       +3     
  Misses       3205     3205              
+ Partials      822      821       -1
Impacted Files Coverage Δ
dipy/tracking/streamline.py 67.96% <100%> (+0.27%) ⬆️
dipy/tracking/tests/test_streamline.py 98.25% <100%> (ø) ⬆️
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55303c...bd69cca. Read the comment docs.

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented May 11, 2018

Hello @arokem, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on July 20, 2018 at 20:20 Hours UTC

@arokem arokem force-pushed the arokem:sl_api_for_orient branch 2 times, most recently from d851e80 to 0cff39b May 12, 2018

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Jul 20, 2018

can you rebase this one @arokem?

@arokem arokem force-pushed the arokem:sl_api_for_orient branch from 0cff39b to bd69cca Jul 20, 2018

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Jul 20, 2018

Rebased! Thanks for reminding me.

@@ -484,7 +484,9 @@ def _orient_list(out, roi1, roi2):
min1 = np.argmin(dist1, 0)
min2 = np.argmin(dist2, 0)
if min1[0] > min2[0]:
out[idx] = sl[::-1]
out[idx][:, 0] = sl[::-1][:, 0]

This comment has been minimized.

@Garyfallidis

Garyfallidis Jul 25, 2018

Member

@arokem what is the difference from before here?

This comment has been minimized.

@arokem

arokem Jul 25, 2018

Member

streamline objects don't let you assign in place

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented Jul 25, 2018

Okay, thanks.

@Garyfallidis Garyfallidis merged commit 6e1da86 into nipy:master Jul 25, 2018

3 checks passed

codecov/patch 100% of diff hit (target 87.33%)
Details
codecov/project 87.34% (+<.01%) compared to b55303c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1515 from arokem/sl_api_for_orient
RF: Use the new Streamlines API for orienting of streamlines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment