New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values from streamlines object #1524

Merged
merged 4 commits into from May 16, 2018

Conversation

Projects
None yet
4 participants
@arokem
Copy link
Member

arokem commented May 16, 2018

Small bug fix, that accommodates use of the new nibabel Streamlines API with this function.

The first commit demonstrates the bug with a test.

The second commit is a one-line change that fixes it.

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented May 16, 2018

Hello @arokem, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on May 16, 2018 at 19:11 Hours UTC
@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented May 16, 2018

great! I saw you made a part of this change on #1515.

After making pep8speak happy, I think it is ready to go.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 16, 2018

Codecov Report

Merging #1524 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
- Coverage   87.55%   87.55%   -0.01%     
==========================================
  Files         246      246              
  Lines       31366    31370       +4     
  Branches     3433     3434       +1     
==========================================
+ Hits        27464    27467       +3     
  Misses       3085     3085              
- Partials      817      818       +1
Impacted Files Coverage Δ
dipy/tracking/tests/test_streamline.py 98.25% <100%> (ø) ⬆️
dipy/tracking/streamline.py 96.06% <100%> (+0.03%) ⬆️
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c7e45...23cb625. Read the comment docs.

@arokem

This comment has been minimized.

Copy link
Member

arokem commented May 16, 2018

PEP8 now fixed, I think?

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented May 16, 2018

pep8speaks said:

Line 600:12: E127 continuation line over-indented for visual indent
Line 601:12: E127 continuation line over-indented for visual indent

@arokem

This comment has been minimized.

Copy link
Member

arokem commented May 16, 2018

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented May 16, 2018

😄 hahaha, Thanks for the advise, I will try to be careful and not listen too much pep8speak 😄

@skoudoro skoudoro merged commit 8462d3e into nipy:master May 16, 2018

3 checks passed

codecov/patch 100% of diff hit (target 87.55%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +12.44% compared to f4c7e45
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment