Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Eigenvalue - eigenvector array compatibility check #1526
If eigenvalues and aigenvector array shapes are not compatible, tensor_slicer actor does not give clear error message. In this PR, compatibility cheking of eigenvalue and eigenvector shapes is added. It gives more clear error when shapes are not compatible.
left a comment
I would probably make this a RuntimeError, so that it differentiates from the error that would be raised later on in the code in case inputs are incompatible.
Then, you could also add a test that checks that this error is raised when inputs are mis-matched.
@@ Coverage Diff @@ ## master #1526 +/- ## ========================================== + Coverage 87.33% 87.33% +<.01% ========================================== Files 246 246 Lines 32171 32177 +6 Branches 3494 3495 +1 ========================================== + Hits 28095 28102 +7 Misses 3242 3242 + Partials 834 833 -1