New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the icon set in Button2D from Dictionary to List of Tuples #1534

Closed
wants to merge 26 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@karandeepSJ
Copy link
Contributor

karandeepSJ commented May 25, 2018

The Button2D class used a dictionary to store icons. The random ordering of dictionaries in Python was causing problems when a particular order was required for the button icons.
This PR changes the dictionary to a list of tuples of the form ((icon_name, icon), (icon_name, icon), ....)

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented May 25, 2018

Hello @karandeepSJ, Thank you for updating !

Line 1584:24: E127 continuation line over-indented for visual indent

Comment last updated on June 04, 2018 at 15:45 Hours UTC

@skoudoro skoudoro added the gsoc2018 label May 25, 2018

karandeepSJ and others added some commits May 26, 2018

Merge pull request #1537 from ShreyasFadnavis/dipy-sims
removed unncessary importd from sims example
Jon Haitz Legarreta
DOC: Update Rafael's current institution.
Update Rafael's current institution.
Merge pull request #1536 from jhlegarreta/UpdateRNHCurrentInstitution
DOC: Update Rafael's current institution.
Merge pull request #1538 from albayenes/fix-explanation-of-code-in-ex…
…ample-reconst-dki

Explanation that is mistakenly rendered as code fixed in example of DKI
Merge pull request #1492 from MarcCote/enh_ui_components_positioning2
Enh ui components positioning (with code refactoring)
@karandeepSJ

This comment has been minimized.

Copy link
Contributor Author

karandeepSJ commented Jun 4, 2018

There seems to be some issue with how I rebased. I'll make a new PR.

@karandeepSJ karandeepSJ closed this Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment