New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential zero division in demon regist. #1540

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
2 participants
@Borda
Copy link
Contributor

Borda commented May 30, 2018

No description provided.

@Borda

This comment has been minimized.

Copy link
Contributor

Borda commented May 30, 2018

it seems that the master is not passing tests...

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented May 30, 2018

Hi @Borda, Thank you for this PR and we know this problem. We are trying to find a solution.

@Borda

This comment has been minimized.

Copy link
Contributor

Borda commented May 30, 2018

@skoudoro seems to be correlated with the recent release of cvxpy, see #1542

@Borda

This comment has been minimized.

Copy link
Contributor

Borda commented Jun 5, 2018

@skoudoro I this that this simple fix can be merged based on the passing tests, what do you think?

@Borda Borda force-pushed the Borda:fix_div_zero branch from 6750558 to fa7b35e Jun 5, 2018

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Jun 5, 2018

Yep, I think it can be merged, just waiting for Travis @Borda

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Jun 5, 2018

Thanks @Borda for this fix!

@skoudoro skoudoro merged commit 4484514 into nipy:master Jun 5, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1540 from Borda/fix_div_zero
fix potential zero division in demon regist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment