New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range slider element for viz.ui #1557

Merged
merged 7 commits into from Jun 15, 2018

Conversation

Projects
5 participants
@karandeepSJ
Copy link
Contributor

karandeepSJ commented Jun 8, 2018

This PR adds two elements to the viz.ui module.

LineDoubleSlider2D

This element allows the user to have two handles on the same slider. These handles can slide on the track, while not crossing each other at any point.
This element is useful for setting a range for a parameter.
For example, in CT images, this can be used to select a mapping for some window of pixel values to values between 0-255.
double slider

RangeSlider

This element uses a LineDoubleSlider2D to select a range which restricts a LineSlider2D to move within that range. This can be useful when a user wants to fine tune the value of a parameter by narrowing the permissible range for that parameter.
rangeslider

Shape of Handles

This PR also gives the user an option to choose the shape of the handles of the sliders. Currently, disk and square are supported. This option is available in LineSlider2D, LineDoubleSlider2D and RangeSlider.

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Jun 8, 2018

Hello @karandeepSJ, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on June 14, 2018 at 03:06 Hours UTC

@dmreagan dmreagan requested review from dmreagan and ranveeraggarwal Jun 9, 2018

@dmreagan dmreagan added this to PR needs a review in Viz Module Jun 9, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #1557 into master will increase coverage by 0.06%.
The diff coverage is 73.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
+ Coverage   87.42%   87.49%   +0.06%     
==========================================
  Files         246      246              
  Lines       31458    31505      +47     
  Branches     3425     3430       +5     
==========================================
+ Hits        27502    27564      +62     
+ Misses       3144     3124      -20     
- Partials      812      817       +5
Impacted Files Coverage Δ
dipy/viz/tests/test_ui.py 84.21% <48.38%> (-3.29%) ⬇️
dipy/viz/ui.py 87.47% <77.46%> (-3.43%) ⬇️
dipy/viz/interactor.py 98.12% <0%> (-0.04%) ⬇️
dipy/tracking/streamline.py 96.06% <0%> (+28.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bfa3ac...297036f. Read the comment docs.

@skoudoro skoudoro added the gsoc2018 label Jun 13, 2018

@karandeepSJ karandeepSJ force-pushed the karandeepSJ:DoubleSlider branch from 23bc20a to 297036f Jun 14, 2018

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented Jun 15, 2018

Okay this good too @karandeepSJ .
Something minor rather than shape I do prefer handle_shape. Do change this in one of your upcoming PRs.

@Garyfallidis Garyfallidis merged commit beca581 into nipy:master Jun 15, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

Viz Module automation moved this from PR needs a review to Done Jun 15, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment