New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing major_version in viz.ui #1563

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
3 participants
@karandeepSJ
Copy link
Contributor

karandeepSJ commented Jun 11, 2018

This PR changes the variable major_version used to check the user's version of the vtk library.
When it need to be used to provide the input to the texture mapper, the set_input function from viz.utils has been used.
At other places, major_version has been replaced with VTK_MAJOR_VERSION.

@dmreagan dmreagan added this to PR needs a review in Viz Module Jun 12, 2018

@skoudoro skoudoro added the gsoc2018 label Jun 13, 2018

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented Jun 15, 2018

Cool, thanks. We are going to deprecate old vtk versions soon. But hey good to keep the standards right.

@Garyfallidis Garyfallidis merged commit e138a31 into nipy:master Jun 15, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

Viz Module automation moved this from PR needs a review to Done Jun 15, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment