New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] #1572

Closed
wants to merge 99 commits into
base: nipy-dipy-master
from

Conversation

Projects
None yet
@ShreyasFadnavis
Copy link
Contributor

ShreyasFadnavis commented Jun 20, 2018

1st Draft

Garyfallidis and others added some commits May 1, 2018

DOC: add some extra indentation, fixes
Adds stuff to Ariel's PR, allowing me to close mine (#1508).
Merge pull request #30 from matthew-brett/add-my-fixes-to-ariels
Pull in extra stuff from my doc PR
Merge pull request #1508 from arokem/math-in-kurtosis
Adds whitespace, to appease the sphinx.
Merge pull request #1510 from ShreyasFadnavis/patch-1
copyright updated to 2008-2018
Merge pull request #1513 from RicciWoo/fix-typo-quick_start
fix typo in example of quick_start
Merge pull request #1514 from skoudoro/adding-pep8-speak
Adding pep8speak config file
Merge pull request #1516 from skoudoro/fix-install-cmd
[DOC] Installation instruction update
Merge pull request #1518 from jchoude/DOC_some_developers_affiliations
DOC: updated some developers affiliations.
Parichit Sharma
Updating the documentation for the workflow creation tutorial.
1) This change will be reflected on the page http://nipy.org/dipy/examples_built/workflow_creation.html#example-workflow-creation
2) Added one more import statement to import the AppendTextFlow method from the workflow class.
3) Added few lines to explain why we need to import the methods.
Parichit Sharma
Removed the trailing whitespaces as per the PEP8 standard.
1) The PEP8 still complains about the maximum line width but no complaints about the
trailing white spaces.
Parichit Sharma
Updated the workflow_creation.py according to the recommendations mad…
…e by Serge

1) Slightly modified the comments to tell that we are creating a separate file called as my_workflow.py in <dipy/workflows> folder.
2) Removed the first line about the import statements.
3) Comments are more precise now.
Merge pull request #1521 from arokem/old_highlights
Moved some older highlights and announcements to the old news files.

skoudoro and others added some commits Jun 5, 2018

Merge pull request #1542 from Borda/fix_4_cvxpy
fix for using cvxpy solver
Merge pull request #1540 from Borda/fix_div_zero
fix potential zero division in demon regist.
Merge pull request #1522 from karandeepSJ/ImageHolder
Image element in dipy.viz.ui
Merge pull request #1547 from karandeepSJ/ButtonDict2List
 Changed the icon set in Button2D from Dictionary to List of Tuples
Merge pull request #1557 from karandeepSJ/DoubleSlider
Range slider element for viz.ui
Merge pull request #1563 from karandeepSJ/vtk_version_check
Replacing major_version in viz.ui
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Jun 20, 2018

Hello @ShreyasFadnavis! Thanks for submitting the PR.

Line 1296:80: E501 line too long (81 > 79 characters)
Line 1297:80: E501 line too long (82 > 79 characters)

Line 510:13: E741 ambiguous variable name 'I'
Line 512:17: E741 ambiguous variable name 'I'
Line 541:9: E741 ambiguous variable name 'I'
Line 544:13: E741 ambiguous variable name 'I'
Line 581:25: E741 ambiguous variable name 'l'
Line 632:21: E741 ambiguous variable name 'l'
Line 1339:13: E741 ambiguous variable name 'l'
Line 1391:13: E741 ambiguous variable name 'l'
Line 1414:13: E741 ambiguous variable name 'l'
Line 1457:13: E741 ambiguous variable name 'l'
Line 1509:13: E741 ambiguous variable name 'l'
Line 1534:13: E741 ambiguous variable name 'l'
Line 1592:13: E741 ambiguous variable name 'l'
Line 1647:13: E741 ambiguous variable name 'l'
Line 1655:41: E741 ambiguous variable name 'l'
Line 1694:17: E741 ambiguous variable name 'l'

Line 823:37: E741 ambiguous variable name 'l'

Line 24:1: E305 expected 2 blank lines after class or function definition, found 0
Line 216:1: E305 expected 2 blank lines after class or function definition, found 1

Line 26:1: E305 expected 2 blank lines after class or function definition, found 0

Line 1009:57: E231 missing whitespace after ','
Line 1009:59: E231 missing whitespace after ','
Line 1026:80: E501 line too long (99 > 79 characters)
Line 1028:80: E501 line too long (91 > 79 characters)
Line 1059:1: E305 expected 2 blank lines after class or function definition, found 1

Line 967:30: E128 continuation line under-indented for visual indent
Line 972:80: E501 line too long (87 > 79 characters)
Line 1040:80: E501 line too long (101 > 79 characters)

Line 327:25: E127 continuation line over-indented for visual indent

Line 3049:80: E501 line too long (81 > 79 characters)
Line 3188:80: E501 line too long (80 > 79 characters)

  • In the file doc/conf.py, following are the PEP8 issues :

Line 6:80: E501 line too long (80 > 79 characters)
Line 14:11: E401 multiple imports on one line
Line 32:80: E501 line too long (80 > 79 characters)
Line 38:80: E501 line too long (80 > 79 characters)
Line 48:29: E261 at least two spaces before inline comment
Line 62:1: E265 block comment should start with '# '
Line 82:1: E265 block comment should start with '# '
Line 86:1: E265 block comment should start with '# '
Line 90:1: E265 block comment should start with '# '
Line 92:1: E265 block comment should start with '# '
Line 95:1: E265 block comment should start with '# '
Line 101:80: E501 line too long (80 > 79 characters)
Line 102:1: E265 block comment should start with '# '
Line 105:1: E265 block comment should start with '# '
Line 109:1: E265 block comment should start with '# '
Line 113:1: E265 block comment should start with '# '
Line 119:1: E265 block comment should start with '# '
Line 122:80: E501 line too long (80 > 79 characters)
Line 136:1: E265 block comment should start with '# '
Line 139:1: E265 block comment should start with '# '
Line 143:1: E265 block comment should start with '# '
Line 146:1: E265 block comment should start with '# '
Line 150:1: E265 block comment should start with '# '
Line 155:1: E265 block comment should start with '# '
Line 164:1: E265 block comment should start with '# '
Line 168:1: E265 block comment should start with '# '
Line 171:1: E265 block comment should start with '# '
Line 175:1: E265 block comment should start with '# '
Line 182:1: E265 block comment should start with '# '
Line 185:1: E265 block comment should start with '# '
Line 188:1: E265 block comment should start with '# '
Line 193:1: E265 block comment should start with '# '
Line 196:1: E265 block comment should start with '# '
Line 202:80: E501 line too long (80 > 79 characters)
Line 205:1: E265 block comment should start with '# '
Line 208:1: E265 block comment should start with '# '
Line 211:80: E501 line too long (80 > 79 characters)
Line 219:1: E265 block comment should start with '# '
Line 223:1: E265 block comment should start with '# '
Line 231:1: E265 block comment should start with '# '
Line 234:1: E265 block comment should start with '# '
Line 239:1: W391 blank line at end of file

Line 6:80: E501 line too long (82 > 79 characters)
Line 21:80: E501 line too long (85 > 79 characters)
Line 25:1: E402 module level import not at top of file
Line 64:1: E402 module level import not at top of file
Line 93:1: E402 module level import not at top of file
Line 108:80: E501 line too long (86 > 79 characters)
Line 114:1: E402 module level import not at top of file
Line 123:1: E402 module level import not at top of file
Line 127:80: E501 line too long (91 > 79 characters)

Line 198:80: E501 line too long (80 > 79 characters)
Line 201:80: E501 line too long (80 > 79 characters)
Line 204:80: E501 line too long (80 > 79 characters)
Line 342:80: E501 line too long (80 > 79 characters)
Line 348:80: E501 line too long (80 > 79 characters)

Line 19:1: E402 module level import not at top of file
Line 47:26: E128 continuation line under-indented for visual indent
Line 54:26: E128 continuation line under-indented for visual indent
Line 57:1: E402 module level import not at top of file
Line 63:1: E265 block comment should start with '# '
Line 85:1: E402 module level import not at top of file
Line 92:80: E501 line too long (88 > 79 characters)

Line 28:1: E402 module level import not at top of file
Line 57:1: E402 module level import not at top of file
Line 70:1: E402 module level import not at top of file
Line 71:1: E402 module level import not at top of file
Line 72:1: E402 module level import not at top of file
Line 102:1: E402 module level import not at top of file

Line 39:1: E402 module level import not at top of file
Line 270:1: E305 expected 2 blank lines after class or function definition, found 1
Line 306:4: W292 no newline at end of file

Line 81:10: E211 whitespace before '('
Line 93:10: E211 whitespace before '('

Line 16:80: E501 line too long (110 > 79 characters)
Line 20:1: E402 module level import not at top of file
Line 26:1: E402 module level import not at top of file
Line 65:80: E501 line too long (80 > 79 characters)
Line 79:1: E305 expected 2 blank lines after class or function definition, found 1
Line 88:80: E501 line too long (80 > 79 characters)
Line 101:80: E501 line too long (84 > 79 characters)
Line 102:80: E501 line too long (81 > 79 characters)
Line 105:1: E402 module level import not at top of file
Line 106:1: E402 module level import not at top of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment