New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bug in PR #1547 #1574

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Projects
4 participants
@karandeepSJ
Copy link
Contributor

karandeepSJ commented Jun 21, 2018

This PR fixes a bug in #1547 and resolves #1573 .

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Jun 21, 2018

Thanks for the quick response. Let's wait for Travis to weigh in on this :-)

@MarcCote
Copy link
Contributor

MarcCote left a comment

LGTM

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Jun 23, 2018

Indeed, this fixes the error that was on master.

The remaining error is due to #1565, so I will go ahead and merge this.

@dmreagan dmreagan added the gsoc2018 label Jun 26, 2018

@dmreagan dmreagan added this to PR needs a review in Viz Module Jun 26, 2018

@arokem arokem merged commit 7f2966d into nipy:master Jun 29, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

Viz Module automation moved this from PR needs a review to Done Jun 29, 2018

arokem added a commit to arokem/dipy that referenced this pull request Jul 19, 2018

dmreagan added a commit that referenced this pull request Jul 20, 2018

Revert 1570 file menu (#1590)
* Revert "Added File Menu element to viz.ui"
* Restore fix implemented in #1574
* Fix typo.
* Fix inputs to Button2D
* Typo: close parentheses.

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Revert 1570 file menu (nipy#1590)
* Revert "Added File Menu element to viz.ui"
* Restore fix implemented in nipy#1574
* Fix typo.
* Fix inputs to Button2D
* Typo: close parentheses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment