New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Needs Optimization and Cleaning #1576

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ShreyasFadnavis
Copy link
Contributor

ShreyasFadnavis commented Jun 22, 2018

  • Possible Speedups

  • Possible Switching between number of Fibers

  • Cleaning up NODDIx and PEP8

ShreyasFadnavis added some commits Jun 20, 2018

@ShreyasFadnavis

This comment has been minimized.

Copy link
Contributor

ShreyasFadnavis commented Jun 22, 2018

@skoudoro you can check this one out!

@skoudoro skoudoro added the gsoc2018 label Jun 26, 2018

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Jun 27, 2018

Hello @ShreyasFadnavis, Thank you for updating !

  • In the file NODDIx.py, following are the PEP8 issues :

Line 403:9: E741 ambiguous variable name 'I'
Line 420:9: E265 block comment should start with '# '
Line 421:9: E265 block comment should start with '# '
Line 426:9: E265 block comment should start with '# '

Line 373:81: E501 line too long (82 > 80 characters)
Line 405:9: E741 ambiguous variable name 'I'

Comment last updated on July 11, 2018 at 17:30 Hours UTC

ShreyasFadnavis added some commits Jun 27, 2018

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Sep 12, 2018

closing in favor of #1600

@skoudoro skoudoro closed this Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment