New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PRE=1 job to fail #1580

Merged
merged 3 commits into from Jul 9, 2018

Conversation

Projects
None yet
4 participants
@skoudoro
Copy link
Member

skoudoro commented Jun 29, 2018

To follow the suggestion on #1579, This PR allow PRE=1 to fail.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 29, 2018

Codecov Report

Merging #1580 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1580      +/-   ##
==========================================
+ Coverage   87.33%   87.33%   +<.01%     
==========================================
  Files         246      246              
  Lines       31931    31931              
  Branches     3471     3471              
==========================================
+ Hits        27887    27888       +1     
  Misses       3217     3217              
+ Partials      827      826       -1
Impacted Files Coverage Δ
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2966d...c325bec. Read the comment docs.

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Jun 29, 2018

What do you think, @matthew-brett? Would this be too subtle?

@matthew-brett

This comment has been minimized.

Copy link
Member

matthew-brett commented Jun 29, 2018

I think that's fine, as long as we check from time to time... Obviously before a release.

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Jul 2, 2018

If we all agreed, I think this PR is ready to go @arokem. We need to put a note on the documentation.

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Jul 4, 2018

@arokem arokem merged commit 9994c2a into nipy:master Jul 9, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@arokem

This comment has been minimized.

Copy link
Member

arokem commented Jul 9, 2018

Thanks!

@skoudoro skoudoro deleted the skoudoro:allow-pre-to-fail branch Jul 9, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment