New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed event.abort for release events #1593

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
4 participants
@karandeepSJ
Copy link
Contributor

karandeepSJ commented Jul 24, 2018

This PR fixes #1586 .
The problem is solved by allowing the mouse release events to propagate by removing i_ren.event.abort()

@skoudoro
Copy link
Member

skoudoro left a comment

Thanks @karandeepSJ for this fix! I just tested it and it works perfectly in my environment.

@dmreagan dmreagan added the gsoc2018 label Jul 26, 2018

@dmreagan dmreagan added this to PR needs a review in Viz Module Jul 26, 2018

@dmreagan
Copy link
Contributor

dmreagan left a comment

Works for me

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Jul 31, 2018

Can you rebase all your PR @karandeepSJ? After that, this one can be merged.
Sorry about that.

@karandeepSJ karandeepSJ force-pushed the karandeepSJ:fix-issue-1586 branch from c38d9c8 to 7ac18b6 Aug 1, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 1, 2018

Codecov Report

Merging #1593 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1593      +/-   ##
==========================================
+ Coverage   87.32%   87.33%   +<.01%     
==========================================
  Files         246      246              
  Lines       31814    31811       -3     
  Branches     3451     3451              
==========================================
- Hits        27783    27781       -2     
+ Misses       3208     3207       -1     
  Partials      823      823
Impacted Files Coverage Δ
dipy/viz/ui.py 88.89% <ø> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405ab40...7ac18b6. Read the comment docs.

@karandeepSJ

This comment has been minimized.

Copy link
Contributor

karandeepSJ commented Aug 1, 2018

Rebased.

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Aug 1, 2018

great, thanks! merging!

Can you do the same with all your other PR ( #1592, #1584, #1564, #1569 )

@skoudoro skoudoro merged commit 0134338 into nipy:master Aug 1, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 405ab40...7ac18b6
Details
codecov/project 87.33% (+<.01%) compared to 405ab40
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Viz Module automation moved this from PR needs a review to Done Aug 1, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1593 from karandeepSJ/fix-issue-1586
Removed event.abort for release events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment