New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tortoise - sub #1610

Closed
wants to merge 15 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@15thai
Copy link

15thai commented Aug 7, 2018

No description provided.

eurotomania added some commits Jul 12, 2018

Add files via upload
Random matrix theory denoising
Add files via upload
Random Matrix theory based denoising
Add files via upload
Added compile support for randommatrix_localpca_parallel.pyx
random matrix theory denoising
Single threaded pure Python version of DWI denoising with Random Matrix Theory
random matrix theory denoising
Cython OpenMP version of DWI denoising with random matrix theory
random matrix theory denoising
Cython OpenMP version of DWI denoising with random matrix theory
Small comments change
Changed some comments and blank spaces.
Changed the output type.
Small comment changes
Small comment changes..
Initial upload of unring.py
Initial upload for Gibbs ringing correction code.
Initial upload of unring.py
Initial upload for Gibbs ringing correction code
Initial upload of the parallel unring
Initial upload of the multi-process version of Gibbs ringing correction code
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Aug 7, 2018

Hello @15thai, Thank you for submitting the Pull Request !

Line 3:23: E231 missing whitespace after ','
Line 6:1: E302 expected 2 blank lines, found 1
Line 13:47: W291 trailing whitespace
Line 35:73: W291 trailing whitespace
Line 38:15: W291 trailing whitespace
Line 51:70: W291 trailing whitespace
Line 57:12: E225 missing whitespace around operator
Line 64:29: E231 missing whitespace after ','
Line 64:49: W291 trailing whitespace
Line 65:1: W293 blank line contains whitespace
Line 66:17: E225 missing whitespace around operator
Line 69:16: E225 missing whitespace around operator
Line 70:1: W293 blank line contains whitespace
Line 71:39: E231 missing whitespace after ','
Line 71:52: E231 missing whitespace after ','
Line 71:66: E231 missing whitespace after ','
Line 71:81: E501 line too long (83 > 80 characters)
Line 72:57: W291 trailing whitespace
Line 74:32: E231 missing whitespace after ','
Line 74:60: W291 trailing whitespace
Line 86:1: W293 blank line contains whitespace
Line 90:49: W291 trailing whitespace
Line 101:45: W291 trailing whitespace
Line 102:52: E231 missing whitespace after ','
Line 103:36: E225 missing whitespace around operator
Line 105:31: E225 missing whitespace around operator
Line 106:39: W291 trailing whitespace
Line 109:22: E225 missing whitespace around operator
Line 113:81: E501 line too long (88 > 80 characters)
Line 113:83: E231 missing whitespace after ','
Line 115:32: E222 multiple spaces after operator
Line 115:42: E231 missing whitespace after ','
Line 115:54: E231 missing whitespace after ','
Line 115:72: E231 missing whitespace after ','
Line 115:81: E501 line too long (98 > 80 characters)
Line 115:91: E231 missing whitespace after ','
Line 117:26: E225 missing whitespace around operator
Line 117:27: E222 multiple spaces after operator
Line 117:50: E231 missing whitespace after ','
Line 118:1: W293 blank line contains whitespace
Line 119:31: E231 missing whitespace after ','
Line 119:33: E231 missing whitespace after ','
Line 119:35: E231 missing whitespace after ','
Line 120:28: E231 missing whitespace after ','
Line 120:30: E231 missing whitespace after ','
Line 120:48: W291 trailing whitespace
Line 121:1: W293 blank line contains whitespace
Line 128:1: W391 blank line at end of file

Line 3:30: E231 missing whitespace after ','
Line 3:35: E231 missing whitespace after ','
Line 3:40: E231 missing whitespace after ','
Line 4:22: E231 missing whitespace after ','
Line 8:19: E231 missing whitespace after ','
Line 8:23: E231 missing whitespace after ','
Line 8:28: E231 missing whitespace after ','
Line 13:13: E225 missing whitespace around operator
Line 15:32: E231 missing whitespace after ','
Line 16:38: E231 missing whitespace after ','
Line 17:37: E231 missing whitespace after ','
Line 17:57: E225 missing whitespace around operator
Line 17:59: W291 trailing whitespace
Line 19:16: E225 missing whitespace around operator
Line 20:24: E225 missing whitespace around operator
Line 22:27: E231 missing whitespace after ','
Line 22:30: E231 missing whitespace after ','
Line 23:28: E231 missing whitespace after ','
Line 23:31: E231 missing whitespace after ','
Line 25:25: E228 missing whitespace around modulo operator
Line 25:44: E225 missing whitespace around operator
Line 27:35: E231 missing whitespace after ','
Line 30:22: E231 missing whitespace after ','
Line 30:25: W291 trailing whitespace
Line 31:13: E231 missing whitespace after ','
Line 31:16: E225 missing whitespace around operator
Line 32:13: E231 missing whitespace after ','
Line 32:16: E225 missing whitespace around operator
Line 32:21: E231 missing whitespace after ','
Line 34:13: E228 missing whitespace around modulo operator
Line 34:18: E225 missing whitespace around operator
Line 35:17: E231 missing whitespace after ','
Line 35:22: E225 missing whitespace around operator
Line 37:56: E225 missing whitespace around operator
Line 42:14: E225 missing whitespace around operator
Line 43:18: E231 missing whitespace after ','
Line 43:32: E225 missing whitespace around operator
Line 43:36: E231 missing whitespace after ','
Line 44:14: E225 missing whitespace around operator
Line 45:18: E231 missing whitespace after ','
Line 45:46: E225 missing whitespace around operator
Line 45:50: E231 missing whitespace after ','
Line 48:18: E225 missing whitespace around operator
Line 48:23: E231 missing whitespace after ','
Line 49:18: E231 missing whitespace after ','
Line 49:21: E225 missing whitespace around operator
Line 51:15: E225 missing whitespace around operator
Line 51:35: E231 missing whitespace after ','
Line 52:15: E225 missing whitespace around operator
Line 52:35: E231 missing whitespace after ','
Line 53:28: E231 missing whitespace after ','
Line 54:22: E221 multiple spaces before operator
Line 54:47: E231 missing whitespace after ','
Line 54:52: E228 missing whitespace around modulo operator
Line 54:60: E221 multiple spaces before operator
Line 54:63: E222 multiple spaces after operator
Line 54:78: E228 missing whitespace around modulo operator
Line 54:81: E501 line too long (86 > 80 characters)
Line 55:22: E221 multiple spaces before operator
Line 55:47: E231 missing whitespace after ','
Line 55:52: E228 missing whitespace around modulo operator
Line 55:60: E221 multiple spaces before operator
Line 55:63: E222 multiple spaces after operator
Line 55:78: E228 missing whitespace around modulo operator
Line 55:81: E501 line too long (86 > 80 characters)
Line 56:22: E221 multiple spaces before operator
Line 56:53: E225 missing whitespace around operator
Line 56:60: E221 multiple spaces before operator
Line 56:63: E222 multiple spaces after operator
Line 56:77: E228 missing whitespace around modulo operator
Line 56:81: E501 line too long (85 > 80 characters)
Line 57:22: E221 multiple spaces before operator
Line 57:51: E228 missing whitespace around modulo operator
Line 57:59: E221 multiple spaces before operator
Line 57:62: E222 multiple spaces after operator
Line 57:77: E228 missing whitespace around modulo operator
Line 57:81: E501 line too long (85 > 80 characters)
Line 63:23: E225 missing whitespace around operator
Line 65:23: E225 missing whitespace around operator
Line 67:58: E228 missing whitespace around modulo operator
Line 67:66: E221 multiple spaces before operator
Line 67:69: E222 multiple spaces after operator
Line 67:81: E501 line too long (94 > 80 characters)
Line 67:86: E228 missing whitespace around modulo operator
Line 68:56: E228 missing whitespace around modulo operator
Line 68:64: E221 multiple spaces before operator
Line 68:67: E222 multiple spaces after operator
Line 68:81: E501 line too long (96 > 80 characters)
Line 68:88: E228 missing whitespace around modulo operator
Line 69:58: E228 missing whitespace around modulo operator
Line 69:66: E221 multiple spaces before operator
Line 69:69: E222 multiple spaces after operator
Line 69:81: E501 line too long (96 > 80 characters)
Line 69:88: E228 missing whitespace around modulo operator
Line 70:56: E228 missing whitespace around modulo operator
Line 70:64: E221 multiple spaces before operator
Line 70:67: E222 multiple spaces after operator
Line 70:81: E501 line too long (94 > 80 characters)
Line 70:86: E228 missing whitespace around modulo operator
Line 72:58: E228 missing whitespace around modulo operator
Line 72:66: E221 multiple spaces before operator
Line 72:69: E222 multiple spaces after operator
Line 72:81: E501 line too long (94 > 80 characters)
Line 72:86: E228 missing whitespace around modulo operator
Line 73:56: E228 missing whitespace around modulo operator
Line 73:64: E221 multiple spaces before operator
Line 73:67: E222 multiple spaces after operator
Line 73:81: E501 line too long (96 > 80 characters)
Line 73:88: E228 missing whitespace around modulo operator
Line 74:58: E228 missing whitespace around modulo operator
Line 74:66: E221 multiple spaces before operator
Line 74:69: E222 multiple spaces after operator
Line 74:81: E501 line too long (96 > 80 characters)
Line 74:88: E228 missing whitespace around modulo operator
Line 75:56: E228 missing whitespace around modulo operator
Line 75:64: E221 multiple spaces before operator
Line 75:67: E222 multiple spaces after operator
Line 75:81: E501 line too long (94 > 80 characters)
Line 75:86: E228 missing whitespace around modulo operator
Line 77:29: E231 missing whitespace after ','
Line 77:35: E228 missing whitespace around modulo operator
Line 78:29: E231 missing whitespace after ','
Line 79:29: E231 missing whitespace after ','
Line 79:35: E228 missing whitespace around modulo operator
Line 80:29: E231 missing whitespace after ','
Line 80:35: E228 missing whitespace around modulo operator
Line 81:29: E231 missing whitespace after ','
Line 82:29: E231 missing whitespace after ','
Line 82:35: E228 missing whitespace around modulo operator
Line 82:43: W291 trailing whitespace
Line 84:14: E225 missing whitespace around operator
Line 87:27: E231 missing whitespace after ','
Line 87:32: E222 multiple spaces after operator
Line 87:57: E225 missing whitespace around operator
Line 89:18: E225 missing whitespace around operator
Line 90:27: E231 missing whitespace after ','
Line 90:32: E222 multiple spaces after operator
Line 90:57: E225 missing whitespace around operator
Line 95:1: E303 too many blank lines (3)
Line 95:20: E231 missing whitespace after ','
Line 95:24: E231 missing whitespace after ','
Line 95:29: E231 missing whitespace after ','
Line 99:12: E225 missing whitespace around operator
Line 100:12: E225 missing whitespace around operator
Line 101:15: E225 missing whitespace around operator
Line 102:15: E225 missing whitespace around operator
Line 107:35: E231 missing whitespace after ','
Line 108:12: E201 whitespace after '('
Line 108:50: W291 trailing whitespace
Line 109:35: E231 missing whitespace after ','
Line 111:31: E231 missing whitespace after ','
Line 111:47: E231 missing whitespace after ','
Line 111:77: E231 missing whitespace after ','
Line 111:81: E501 line too long (96 > 80 characters)
Line 111:93: E231 missing whitespace after ','
Line 112:33: E225 missing whitespace around operator
Line 113:1: W293 blank line contains whitespace
Line 114:11: E222 multiple spaces after operator
Line 114:32: E231 missing whitespace after ','
Line 114:48: E231 missing whitespace after ','
Line 114:64: E202 whitespace before ')'
Line 114:66: E221 multiple spaces before operator
Line 114:81: E501 line too long (81 > 80 characters)
Line 115:11: E222 multiple spaces after operator
Line 115:32: E231 missing whitespace after ','
Line 115:48: E231 missing whitespace after ','
Line 115:64: E202 whitespace before ')'
Line 115:66: E221 multiple spaces before operator
Line 115:81: E501 line too long (93 > 80 characters)
Line 117:15: E225 missing whitespace around operator
Line 118:15: E225 missing whitespace around operator
Line 120:31: E231 missing whitespace after ','
Line 120:35: E231 missing whitespace after ','
Line 120:40: E231 missing whitespace after ','
Line 121:31: E231 missing whitespace after ','
Line 121:35: E231 missing whitespace after ','
Line 121:40: E231 missing whitespace after ','
Line 123:12: E225 missing whitespace around operator
Line 124:12: E225 missing whitespace around operator
Line 139:47: W291 trailing whitespace
Line 157:15: W291 trailing whitespace
Line 169:64: W291 trailing whitespace
Line 176:12: E225 missing whitespace around operator
Line 176:38: E231 missing whitespace after ','
Line 176:51: E231 missing whitespace after ','
Line 176:64: E231 missing whitespace after ','
Line 177:1: W293 blank line contains whitespace
Line 178:5: E265 block comment should start with '# '
Line 179:54: W291 trailing whitespace
Line 182:38: W291 trailing whitespace
Line 185:31: E231 missing whitespace after ','
Line 185:33: E231 missing whitespace after ','
Line 185:35: E231 missing whitespace after ','
Line 185:40: W291 trailing whitespace
Line 186:53: E231 missing whitespace after ','
Line 186:58: E231 missing whitespace after ','
Line 187:25: E231 missing whitespace after ','
Line 187:27: E231 missing whitespace after ','
Line 187:29: E231 missing whitespace after ','
Line 187:34: E225 missing whitespace around operator
Line 192:1: W391 blank line at end of file

Line 8:1: E302 expected 2 blank lines, found 1
Line 9:4: E111 indentation is not a multiple of four
Line 10:4: E111 indentation is not a multiple of four
Line 10:12: E225 missing whitespace around operator
Line 12:4: E111 indentation is not a multiple of four
Line 13:4: E111 indentation is not a multiple of four
Line 13:10: E225 missing whitespace around operator
Line 15:4: E111 indentation is not a multiple of four
Line 15:33: W291 trailing whitespace
Line 16:8: E111 indentation is not a multiple of four
Line 16:31: E231 missing whitespace after ','
Line 16:33: E231 missing whitespace after ','
Line 16:35: E231 missing whitespace after ','
Line 16:40: W291 trailing whitespace
Line 17:8: E111 indentation is not a multiple of four
Line 17:48: E231 missing whitespace after ','
Line 17:53: E231 missing whitespace after ','
Line 18:8: E111 indentation is not a multiple of four
Line 18:16: E231 missing whitespace after ','
Line 18:18: E231 missing whitespace after ','
Line 18:20: E231 missing whitespace after ','
Line 18:25: E225 missing whitespace around operator
Line 18:43: W291 trailing whitespace
Line 20:1: E302 expected 2 blank lines, found 1
Line 20:23: E231 missing whitespace after ','
Line 20:38: E231 missing whitespace after ','
Line 20:49: E231 missing whitespace after ','
Line 21:5: E265 block comment should start with '# '
Line 22:39: E231 missing whitespace after ','
Line 22:49: E231 missing whitespace after ','
Line 22:53: E231 missing whitespace after ','
Line 22:58: E231 missing whitespace after ','
Line 24:35: W291 trailing whitespace
Line 25:14: E225 missing whitespace around operator
Line 25:25: W291 trailing whitespace
Line 26:8: E225 missing whitespace around operator
Line 27:9: E225 missing whitespace around operator
Line 28:9: E225 missing whitespace around operator
Line 31:64: E231 missing whitespace after ','
Line 31:81: E501 line too long (82 > 80 characters)
Line 38:47: W291 trailing whitespace
Line 50:81: E501 line too long (85 > 80 characters)
Line 58:15: W291 trailing whitespace
Line 67:64: W291 trailing whitespace
Line 74:12: E225 missing whitespace around operator
Line 74:38: E231 missing whitespace after ','
Line 74:51: E231 missing whitespace after ','
Line 74:64: E231 missing whitespace after ','
Line 82:5: E265 block comment should start with '# '
Line 83:11: E225 missing whitespace around operator
Line 83:53: E231 missing whitespace after ','
Line 83:81: E501 line too long (105 > 80 characters)
Line 85:17: E225 missing whitespace around operator
Line 86:22: E225 missing whitespace around operator
Line 87:5: E265 block comment should start with '# '
Line 88:12: E225 missing whitespace around operator
Line 88:54: E231 missing whitespace after ','
Line 88:81: E501 line too long (106 > 80 characters)
Line 90:18: E225 missing whitespace around operator
Line 91:5: E265 block comment should start with '# '
Line 92:11: E225 missing whitespace around operator
Line 92:16: E231 missing whitespace after ','
Line 92:21: E231 missing whitespace after ','
Line 94:5: E265 block comment should start with '# '
Line 95:53: E231 missing whitespace after ','
Line 95:81: E501 line too long (129 > 80 characters)
Line 95:92: E231 missing whitespace after ','
Line 95:104: E231 missing whitespace after ','
Line 95:114: E231 missing whitespace after ','
Line 97:13: W291 trailing whitespace
Line 98:1: W293 blank line contains whitespace
Line 100:5: E303 too many blank lines (2)
Line 100:81: E501 line too long (90 > 80 characters)
Line 103:1: W391 blank line at end of file

Do see the DIPY coding Style guideline

@15thai 15thai closed this Aug 7, 2018

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented Aug 10, 2018

@15thai I see that this PR was opened and then closed. Let me know if you have any questions.

@15thai

This comment has been minimized.

Copy link

15thai commented Aug 10, 2018

I am so sorry, I just started using git, and then pulling this request by accident. Please excuse me and thank you for reaching out to me.

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented Aug 10, 2018

No problem. Keep it up! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment