New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] update VTK version #1619

Merged
merged 2 commits into from Aug 22, 2018

Conversation

Projects
3 participants
@cgangwar11
Copy link
Contributor

cgangwar11 commented Aug 20, 2018

Documentation update to show proper warnings for python versions to be used with VTK 7 and VTK < 7 .

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Aug 20, 2018

Thank you for doing this @cgangwar11!

Looks good to me, Can you have a quick look @dmreagan before merging

@skoudoro skoudoro changed the title Dev chandan [DOC] update VTK version Aug 20, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 20, 2018

Codecov Report

Merging #1619 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
- Coverage   87.34%   87.31%   -0.04%     
==========================================
  Files         246      246              
  Lines       31811    31811              
  Branches     3451     3451              
==========================================
- Hits        27785    27775      -10     
- Misses       3204     3212       +8     
- Partials      822      824       +2
Impacted Files Coverage Δ
dipy/reconst/forecast.py 90.15% <0%> (-2.08%) ⬇️
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️
dipy/reconst/mapmri.py 90.28% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6aa5a...56544fc. Read the comment docs.

@dmreagan dmreagan added this to PR needs a review in Viz Module Aug 21, 2018

@skoudoro skoudoro merged commit a1e1f2e into nipy:master Aug 22, 2018

2 of 3 checks passed

codecov/project 87.31% (-0.04%) compared to 5a6aa5a
Details
codecov/patch Coverage not affected when comparing 5a6aa5a...56544fc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Viz Module automation moved this from PR needs a review to Done Aug 22, 2018

@cgangwar11 cgangwar11 deleted the cgangwar11:dev-chandan branch Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment