New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] viz slice example #1622

Merged
merged 6 commits into from Aug 30, 2018

Conversation

Projects
4 participants
@skoudoro
Copy link
Member

skoudoro commented Aug 22, 2018

viz slice example was broken because of the viz new grid system so this is just an update.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #1622 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         246      245       -1     
  Lines       32164    32148      -16     
  Branches     3497     3493       -4     
==========================================
- Hits        28089    28073      -16     
  Misses       3242     3242              
  Partials      833      833
Impacted Files Coverage Δ
dipy/tracking/tests/test_localtrack.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e1f2e...9b986d4. Read the comment docs.

@@ -170,8 +170,8 @@

lengths = length(bundle_native)

hue = [0.5, 0.5] # red only

This comment has been minimized.

@arokem

arokem Aug 22, 2018

Member

I am confused by the comment here. This is the same as above, so how could they both be red only?

This comment has been minimized.

@skoudoro

skoudoro Aug 22, 2018

Member

Good catch! should be blue here. here the fix

@dmreagan dmreagan added this to PR needs a review in Viz Module Aug 29, 2018

@dmreagan dmreagan merged commit 570587e into nipy:master Aug 30, 2018

2 of 3 checks passed

codecov/project 87.32% (-0.01%) compared to a1e1f2e
Details
codecov/patch Coverage not affected when comparing a1e1f2e...9b986d4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Viz Module automation moved this from PR needs a review to Done Aug 30, 2018

@skoudoro skoudoro deleted the skoudoro:fix-viz-slice branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment