Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Workflows - Adding PFT, probabilistic, closestpeaks tracking #1640
That looks good, thanks for doing this. See below some quick thought, I will review the code later this week.
I'm not a fan of using the
Some minor things:
Thank you really much for this feedback @gabknight!
I agree with your analysis. We need to have this 2 options, so I think I will add another workflow which manages the second case
good catch, I will update that point
Maybe we should enforce in the code... This is a point to discuss
@@ Coverage Diff @@ ## master #1640 +/- ## ========================================= Coverage ? 84.27% ========================================= Files ? 115 Lines ? 13606 Branches ? 2144 ========================================= Hits ? 11466 Misses ? 1643 Partials ? 497
gabknight left a comment •
Looks good to me. See my comment for a minor change in the selection of tracking algorithm.
I also suggest to rename the workflows as following:
Thanks for putting this together,