New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash for SCIL b0 file #1643

Merged
merged 3 commits into from Sep 23, 2018

Conversation

Projects
None yet
4 participants
@arokem
Copy link
Member

arokem commented Sep 18, 2018

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 18, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@b07f6d9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1643   +/-   ##
=========================================
  Coverage          ?   87.34%           
=========================================
  Files             ?      246           
  Lines             ?    32323           
  Branches          ?     3511           
=========================================
  Hits              ?    28233           
  Misses            ?     3250           
  Partials          ?      840
Impacted Files Coverage Δ
dipy/data/fetcher.py 45.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07f6d9...a6b7d6a. Read the comment docs.

@skoudoro
Copy link
Member

skoudoro left a comment

Thanks @arokem for the fix #1638.

Can you do the small correction below and I can merge this PR.

@@ -371,7 +371,7 @@ def fetcher():
UW_RW_URL + "1773/38479/",
['datasets_multi-site_all_companies.zip'],
['datasets_multi-site_all_companies.zip'],
None,
"e9810fa5bf21b99da786647994d7d5b7",

This comment has been minimized.

@skoudoro

skoudoro Sep 19, 2018

Member

MD5 should be in a list, it misses the bracket here. Otherwise you get the following error:

FetcherError: The downloaded file, /Users/koudoro/.dipy/datasets_multi-site_all_companies.zip, does not have the expected md5
   checksum of "e". Instead, the md5 checksum was: "e9810fa5bf21b99da786647994d7d5b7". This could mean that
   something is wrong with the file or that the upstream file has been updated.
   You can try downloading the file again or updating to the newest version of dipy.
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Sep 19, 2018

Hello @arokem! Thanks for updating the PR.

Line 335:75: E502 the backslash is redundant between brackets
Line 376:75: E502 the backslash is redundant between brackets
Line 886:1: W293 blank line contains whitespace

Comment last updated on September 22, 2018 at 20:58 Hours UTC

@skoudoro skoudoro merged commit 6713a55 into master Sep 23, 2018

2 of 3 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Sep 23, 2018

Thank you @arokem for this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment