New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an Appveyor badge #1644

Merged
merged 1 commit into from Sep 23, 2018

Conversation

Projects
None yet
2 participants
@arokem
Copy link
Member

arokem commented Sep 18, 2018

No description provided.

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Sep 18, 2018

Submitted this also just to see that Appveyor kicks in for every PR. Seems to work!

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Sep 18, 2018

Nice!

I wonder if we want the appveyor/branch and travis-ci/push build. Maybe we should deactivate this 2

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Sep 18, 2018

Oh yeah. I think that I just turned off the push builds on Travis. Can't really find how to turn off the branch builds on Appveyor.

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Sep 18, 2018

Oh yeah - looks like #1645 only has the two PR builds. Those are the ones we want, right?

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Sep 18, 2018

yes, looks good! Thank you for setting up this! Next step: pytest

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Sep 19, 2018

I do not know why, but the last build failed after 1min on Appveyor. Can you rerun this build?

Could you add me as admin on Appveyor @arokem? Thanks!

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Sep 20, 2018

I don't see anywhere that I can add you. I think it should inherit the permissions from Github. Are you unable to see the settings?

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Sep 20, 2018

Also, looks like I can only build the entire PR (all builds), so I did that.

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Sep 20, 2018

Also, looks like I can only build the entire PR (all builds), so I did that.

yeah 😞, unfortunately Appveyor did not implement this functionality apparently....

Are you unable to see the settings?

No on Appveyor, yes on github. I really do not how you can add me, the doc is not clear...

@skoudoro skoudoro merged commit 22cd6dd into master Sep 23, 2018

3 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment