Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
STYLE: Honor 'descoteaux'and 'tournier' SH basis naming. #1658
Honor the authors in the naming for SH basis choice: replace and deprecate
The change includes:
According to what was discussed in #1653.
And thus, closing that one.
A few additional comments as a follow up to the discussion in the previous PR:
So I assume that in shm.py
was not accurate/misworded. According to what Donald stated, I assume MRtrix3 has a basis which is not 2004 or 2007 (I guess it is 2007 with the correction factor). And this is effectively been pointed in the docs, Ch. 33, or the 2012 MRtrix reference pointed by @arokem if we want).
Since DIPY implements 2007 without the correction factor, just as originally published by Tournier, I changed the line above to:
Some refs to
Thanks for the discussions in the previous PR.
@@ Coverage Diff @@ ## master #1658 +/- ## ========================================= Coverage ? 87.37% ========================================= Files ? 246 Lines ? 32789 Branches ? 3570 ========================================= Hits ? 28648 Misses ? 3278 Partials ? 863