New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPT - moved the tolerance check outside of the for loop #1660

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
3 participants
@danielenricocahall
Copy link
Contributor

danielenricocahall commented Oct 29, 2018

I moved the conditional which assigned "tolerance" if it was None outside of the for-loop, as that check only needs to be done once.

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Oct 30, 2018

Great! Thanks for this update @danielenricocahall.

I will merge it when Travis and Appeyor are happy

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 30, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@c0daaeb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1660   +/-   ##
=========================================
  Coverage          ?   87.58%           
=========================================
  Files             ?      248           
  Lines             ?    34109           
  Branches          ?     3740           
=========================================
  Hits              ?    29875           
  Misses            ?     3342           
  Partials          ?      892
Impacted Files Coverage Δ
dipy/segment/tissue.py 73.17% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0daaeb...0e31701. Read the comment docs.

@skoudoro skoudoro merged commit 01a2994 into nipy:master Oct 30, 2018

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment