New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the points added oustide of a mask. Fix the related tests. #1662

Closed
wants to merge 20 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@czotti
Copy link

czotti commented Nov 2, 2018

This PR is to address the issue #1661.

  • It change the way points are added to a streamline if the point is outside the mask.
  • I changed all the needed test.

Unfortunately, one test is failing on the travis-ci when the visu is enabled. You are currently removing this from dipy (#1659) do you want it to be fixed (@skoudoro)?
@gabknight, @jchoude.

@czotti

This comment has been minimized.

Copy link

czotti commented Nov 5, 2018

Ready for review, @gabknight, @jchoude.

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Nov 6, 2018

do you want it to be fixed (@skoudoro)

ok, it's fine. Do not forget to rebase it when #1659 is in.

FYI, DIPY release 0.15.0 is just waiting for #1659. I would recommend @gabknight and @jchoude to review this PR as soon as possible if they want to see this one in.

skoudoro and others added some commits Nov 7, 2018

Merge pull request #1657 from jhlegarreta/AddSHBasisTheoryDoc
DOC: Add spherical harmonics basis documentation.
Merge pull request #1621 from skoudoro/warning-cli
workflows : warn user for strange b0 threshold
Merge pull request #1659 from skoudoro/to-fury
From dipy.viz to FURY
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 19, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@01a2994). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1662   +/-   ##
=========================================
  Coverage          ?   77.85%           
=========================================
  Files             ?      248           
  Lines             ?    34131           
  Branches          ?     3746           
=========================================
  Hits              ?    26573           
  Misses            ?     6844           
  Partials          ?      714
Impacted Files Coverage Δ
dipy/tracking/local/tests/test_tracking.py 95.58% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a2994...0119a40. Read the comment docs.

@czotti czotti closed this Nov 19, 2018

@czotti czotti deleted the czotti:localtracking-drop-points branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment