Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the points added oustide of a mask. Fix the related tests. #1666

Merged
merged 2 commits into from Feb 8, 2019

Conversation

@czotti
Copy link
Contributor

commented Nov 19, 2018

This PR is to address the issue #1661.
I recreate a PR because I made a mistake during the rebase.

  • It change the way points are added to a streamline if the point is outside the mask.
  • I changed all the needed test.
@codecov-io

This comment has been minimized.

Copy link

commented Nov 19, 2018

Codecov Report

Merging #1666 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
- Coverage   84.27%   84.26%   -0.01%     
==========================================
  Files         115      115              
  Lines       13606    13606              
  Branches     2144     2144              
==========================================
- Hits        11466    11465       -1     
  Misses       1643     1643              
- Partials      497      498       +1
Impacted Files Coverage Δ
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️
@guaje

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

Thanks, @czotti for your contribution. We're going to merge these changes.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

+1, Thanks @czotti, Can you rebase this PR before I merge it

@czotti

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2019

One test failing because it's unable to get python 3.5 from s3: https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/14.04/x86_64/python-3.5.tar.bz2

The second fails is due to Cython unable to compile: dipy.tracking.fbcmeasures.

As far as I know, it's not related to my commit no?

@skoudoro

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

One test failing because it's unable to get python 3.5 from s3

I just restarted this build

As far as I know, it's not related to my commit no?

No, it is not related, DIPY is failing with the future Cython release, we have to fix it.

@skoudoro skoudoro merged commit 43c8324 into nipy:master Feb 8, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 9606c64...1bb4a56
Details
codecov/project 84.26% (-0.01%) compared to 9606c64
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Merging, Thank you @czotti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.