Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Changing the default b0_threshold in gtab #1667
Thank @ShreyasFadnavis for this.
Can you update
I think we should warn the user when they are doing something strange. So you should compare
referenced this pull request
Nov 23, 2018
@@ Coverage Diff @@ ## master #1667 +/- ## ======================================== Coverage ? 84.1% ======================================== Files ? 113 Lines ? 13508 Branches ? 2125 ======================================== Hits ? 11361 Misses ? 1650 Partials ? 497
I wonder whether it would be worth adding a test that exercises this. I think we can do that on a separate PR, but if you could open an issue so that we remember to do that, it would help.…
On Thu, Dec 6, 2018 at 9:14 AM Shreyas Fadnavis ***@***.***> wrote: *@ShreyasFadnavis* commented on this pull request. ------------------------------ In dipy/reconst/ivim.py <#1667 (comment)>: > @@ -381,7 +391,7 @@ def estimate_f_D_star(self, params_f_D_star, data, S0, D): warningMsg += " as initial guess for leastsq. Parameters are" warningMsg += " returned only from the linear fit." warnings.warn(warningMsg, UserWarning) - f, D_star = params_f_D + f, D_star = params_f_D_star @arokem <https://github.com/arokem> yes! It was just a minor bug in the code.. I found it while reading it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1667 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHPNgy-W3_P7GlmzAAr86C5UufE9uqkks5u2VCDgaJpZM4Yvf1i> .