New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed RecoBundle workflow, SLR reference, and updated fetcher.py #1670

Merged
merged 2 commits into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@BramshQamar
Copy link
Contributor

BramshQamar commented Nov 26, 2018

  • Fixed issues with dipy_recobundle workflow
  • Updated dipy_slr workflow references
  • Updated fetcher link for new atlas with 80 bundles
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 27, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@a7bb518). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1670   +/-   ##
=========================================
  Coverage          ?   88.49%           
=========================================
  Files             ?      233           
  Lines             ?    29281           
  Branches          ?     3222           
=========================================
  Hits              ?    25911           
  Misses            ?     2701           
  Partials          ?      669
Impacted Files Coverage Δ
dipy/workflows/align.py 95.45% <ø> (ø)
dipy/align/streamlinear.py 87.22% <ø> (ø)
dipy/workflows/segment.py 72.44% <0%> (ø)
dipy/data/fetcher.py 33.24% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bb518...ae63b94. Read the comment docs.

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented Nov 27, 2018

Hi @BramshQamar What about the tutorial in doc/examples? Does this needs to be updated?

@BramshQamar

This comment has been minimized.

Copy link
Contributor

BramshQamar commented Nov 27, 2018

Hi @BramshQamar What about the tutorial in doc/examples? Does this needs to be updated?

Hi @Garyfallidis,
I don't think it needs to be updated. we are using same format just links for fetcher have been updated.

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented Nov 28, 2018

Thanks Bramsh!

@Garyfallidis Garyfallidis merged commit e522f08 into nipy:master Nov 28, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment