New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy matrix deprecation #1678

Merged
merged 2 commits into from Dec 2, 2018

Conversation

Projects
None yet
3 participants
@arokem
Copy link
Member

arokem commented Dec 1, 2018

This should take care of a lot of the PendingDeprecation warnings we are seeing in our CI.

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Dec 1, 2018

I've also submitted cvxgrp/cvxpy#637, cvxgrp/cvxpy#638, which should take care of some of the warnings we are getting from cvxpy.

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Dec 1, 2018

Awesome! waiting for Travis.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 1, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@6e2b002). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1678   +/-   ##
=========================================
  Coverage          ?   84.21%           
=========================================
  Files             ?      113           
  Lines             ?    13490           
  Branches          ?     2121           
=========================================
  Hits              ?    11361           
  Misses            ?     1637           
  Partials          ?      492
Impacted Files Coverage Δ
dipy/reconst/mapmri.py 91.47% <100%> (ø)
dipy/tracking/life.py 97.8% <100%> (ø)

@skoudoro skoudoro merged commit cc632c4 into nipy:master Dec 2, 2018

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Dec 2, 2018

Thank you!

jhlegarreta added a commit to jhlegarreta/dipy that referenced this pull request Dec 26, 2018

BUG: Address `numpy.matrix` `PendingDeprecation` warnings.
Address `numpy.matrix` `PendingDeprecation` warnings:
- Change the uses of `numpy.matrix` to `numpy.array`.
- Change the use of `numpy.matrix.trace` to `numpy.trace`.

Fixes warnings:
```
/home/travis/build/nipy/dipy/venv/lib/python3.4/site-packages/numpy/matrixlib/defmatrix.py:68:
PendingDeprecationWarning: the matrix subclass is not the recommended
way to represent matrices or deal with linear algebra (see
https://docs.scipy.org/doc/numpy/user/numpy-for-matlab-users.html).
Please adjust your code to use regular ndarray.
  return matrix(data, dtype=dtype, copy=False)
```

This should complete the work in PR nipy#1678.

jhlegarreta added a commit to jhlegarreta/dipy that referenced this pull request Dec 30, 2018

BUG: Address `numpy.matrix` `PendingDeprecation` warnings.
Address `numpy.matrix` `PendingDeprecation` warnings:
- Change the uses of `numpy.matrix` to `numpy.array`.
- Change the use of `numpy.matrix.trace` to `numpy.trace`.

Fixes warnings:
```
/home/travis/build/nipy/dipy/venv/lib/python3.4/site-packages/numpy/matrixlib/defmatrix.py:68:
PendingDeprecationWarning: the matrix subclass is not the recommended
way to represent matrices or deal with linear algebra (see
https://docs.scipy.org/doc/numpy/user/numpy-for-matlab-users.html).
Please adjust your code to use regular ndarray.
  return matrix(data, dtype=dtype, copy=False)
```

This should complete the work in PR nipy#1678.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment