New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] workflow variable string #1680

Merged
merged 6 commits into from Dec 8, 2018

Conversation

Projects
None yet
3 participants
@skoudoro
Copy link
Member

skoudoro commented Dec 4, 2018

The aim of this PR is to fix #1338.

This allows variable string type for self.get_io_iterator() function

skoudoro added some commits Dec 6, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 7, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@96d0e73). Click here to learn what that means.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1680   +/-   ##
=========================================
  Coverage          ?   84.14%           
=========================================
  Files             ?      113           
  Lines             ?    13528           
  Branches          ?     2133           
=========================================
  Hits              ?    11383           
  Misses            ?     1651           
  Partials          ?      494
Impacted Files Coverage Δ
dipy/workflows/io.py 89.79% <100%> (ø)
dipy/workflows/base.py 78.8% <68.75%> (ø)
dipy/workflows/multi_io.py 71.73% <79.16%> (ø)

@Garyfallidis Garyfallidis merged commit d0de4d3 into nipy:master Dec 8, 2018

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented Dec 8, 2018

Thanks for the fix Serge.

@skoudoro skoudoro deleted the skoudoro:issue-1338-workflow-variable-string branch Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment