New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize workflow #1686

Merged
merged 9 commits into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@skoudoro
Copy link
Member

skoudoro commented Dec 10, 2018

A quick PR to clean a little bit all workflows

  • Standardize some positional arguments: It helps with parsing.
  • Docstring correction, it was missing some optional keywords
  • fix some pep8 issues
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 11, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@d7c0dc1). Click here to learn what that means.
The diff coverage is 93.65%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1686   +/-   ##
=========================================
  Coverage          ?   84.28%           
=========================================
  Files             ?      114           
  Lines             ?    13557           
  Branches          ?     2139           
=========================================
  Hits              ?    11427           
  Misses            ?     1635           
  Partials          ?      495
Impacted Files Coverage Δ
dipy/io/image.py 100% <ø> (ø)
dipy/workflows/mask.py 94.73% <ø> (ø)
dipy/workflows/reconst.py 77.49% <100%> (ø)
dipy/workflows/denoise.py 40% <33.33%> (ø)
dipy/workflows/stats.py 90.54% <86.66%> (ø)
@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented Dec 11, 2018

Release time! Bring it Serge!

@Garyfallidis Garyfallidis merged commit 52cb7c6 into nipy:master Dec 11, 2018

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:standardize-reconst-workflow branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment