Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in release notes #1690

Merged
merged 3 commits into from Dec 17, 2018

Conversation

@arokem
Copy link
Member

commented Dec 14, 2018

Sorry for only noticing this now. I do believe @wasserth spells his name with a "K": https://www.dkfz.de/en/mic/team/people/Jakob_Wasserthal.html

@skoudoro

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

good catch! Sorry about that...

Can you correct it on AUTHOR file and .mailmap file?

@codecov-io

This comment has been minimized.

Copy link

commented Dec 14, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@7e689f7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1690   +/-   ##
=========================================
  Coverage          ?   84.25%           
=========================================
  Files             ?      114           
  Lines             ?    13557           
  Branches          ?     2139           
=========================================
  Hits              ?    11422           
  Misses            ?     1638           
  Partials          ?      497
@wasserth

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

With "k" is the correct spelling. Thanks for spotting that typo ;).

@skoudoro

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

Can you update AUTHOR file and .mailmap file too @arokem?

arokem added 2 commits Dec 17, 2018
@arokem

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2018

done!

@skoudoro

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

Great, Thank you! merging!

@skoudoro skoudoro merged commit f2c6437 into master Dec 17, 2018

0 of 3 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@skoudoro skoudoro deleted the typo-jakob branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.