Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix `dipy.io.trackvis` deprecation warnings. #1702

Merged
merged 1 commit into from Dec 28, 2018

Conversation

@jhlegarreta
Copy link
Contributor

commented Dec 24, 2018

Fix dipy.io.trackvis deprecation warnings: substitute by
dipy.io.streamline as per the DIPY 0.14. API changes:
https://github.com/nipy/dipy/blob/master/doc/api_changes.rst

Partially addresses #1664.

BUG: Fix `dipy.io.trackvis` deprecation warnings.
Fix `dipy.io.trackvis` deprecation warnings: substitute by
`dipy.io.streamline` as per the DIPY 0.14. API changes:
https://github.com/nipy/dipy/blob/master/doc/api_changes.rst

Partially addresses #1664.
@pep8speaks

This comment has been minimized.

Copy link

commented Dec 24, 2018

Hello @jhlegarreta, Thank you for submitting the Pull Request !

Line 68:1: E402 module level import not at top of file

Line 63:1: E402 module level import not at top of file

Do see the DIPY coding Style guideline

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2018

Nice PEP8 checker bot !

@arokem I guess the module level import next to where the classes/methods are needed is done on purpose, so I guess it it fair to skip the warnings. Let me know if they should be addressed.

@arokem

This comment has been minimized.

Copy link
Member

commented Dec 24, 2018

Yep. LGTM, and I wouldn't worry about the PEP8. Let's just make sure the CI runs cleanly before merging this.

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2018

The reported test failure is related to #1698.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

+1 for merging

@arokem

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

Off we go...

@arokem arokem merged commit d744404 into nipy:master Dec 28, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jhlegarreta jhlegarreta deleted the jhlegarreta:FixTrackvisDeprecationWarnings branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.