Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix blank image being recorded at `linear_fascicle_evaluation.py`. #1703

Conversation

@jhlegarreta
Copy link
Contributor

commented Dec 24, 2018

Fix blank image being recorded at linear_fascicle_evaluation.py:
provide the fury.window.record method with the rendered scene.

Fixes #1633.

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2018

@kesshijordan Please review.

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2018

A few thoughts:

  1. May be fury.window.record should return an error message if no vtk.vtkRenderer is provided rather than creating one with no information.
  2. Since a single frame is provided, there is no real video recording in the example, but a frame being written as a single image.
@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 25, 2018

The reported test failure is related to #1698.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

Thank you for this @jhlegarreta.

LGTM, I made this correction before generating the documentation and it works correctly. It can be merged after #1698

BUG: Fix blank image being recorded at `linear_fascicle_evaluation.py`.
Fix blank image being recorded at `linear_fascicle_evaluation.py`:
provide the `fury.window.record` method with the rendered scene.

Fixes #1633.

@jhlegarreta jhlegarreta force-pushed the jhlegarreta:FixBlankImageRecordedLinearFascicleEvaluationExample branch from 231d036 to 309c995 Dec 30, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Dec 30, 2018

Codecov Report

Merging #1703 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
+ Coverage   84.26%   84.27%   +<.01%     
==========================================
  Files         114      114              
  Lines       13556    13556              
  Branches     2139     2139              
==========================================
+ Hits        11423    11424       +1     
  Misses       1637     1637              
+ Partials      496      495       -1
Impacted Files Coverage Δ
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

@skoudoro skoudoro merged commit 349e6b1 into nipy:master Dec 30, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 58393aa...309c995
Details
codecov/project 84.27% (+<.01%) compared to 58393aa
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jhlegarreta jhlegarreta deleted the jhlegarreta:FixBlankImageRecordedLinearFascicleEvaluationExample branch Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.