Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
BUG: Fix Cython one-liner non-trivial type declaration warnings. #1706
Fix Cython one-liner non-trivial type declaration warnings. Fixes
Although this is just a matter of styles or tastes, the CI output is read many more times than the Cython code is read/written, so I guess it it is worthwhile removing some clutter from the CI log.
Not sure whether this will change with Cython versions or else, whether it can actually be addressed in some more elegant way.
@@ Coverage Diff @@ ## master #1706 +/- ## ========================================= Coverage ? 84.23% ========================================= Files ? 114 Lines ? 13556 Branches ? 2139 ========================================= Hits ? 11419 Misses ? 1640 Partials ? 497
Fix Cython one-liner non-trivial type declaration warnings. Fixes ``` dipy/tracking/distances.pyx:246:14: Non-trivial type declarators in shared declaration (e.g. mix of pointers and values). Each pointer declaration should be on its own line. ``` and similars.
I would not mind to contribute with a Cython style guide.
To be honest, I have not written a single Cython line (yet), so I'd need help from you. When opening the DIPY Cython files, PEP8 points at a few lines. So having a look at those could be useful when writing the guide if we adopt PEP8 as Elef suggested in #583. We could start with an initial version, and thus, a baseline over which make improvements would exist as we come along with related issues/questions.
So we can discuss further in #583 if you wish.