Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
DOC: Add Cython style guideline for DIPY. #1714
A very first draft.
Please have your say about them: either that we should incorporate them to the guideline as they are, or that we want to add them with specific changes.
One controversial point may be that of the
since my experience writing/reading Cython code is limited. So suggestions for content are welcome.
@@ Coverage Diff @@ ## master #1714 +/- ## ======================================== Coverage ? 84.3% ======================================== Files ? 115 Lines ? 13790 Branches ? 2186 ======================================== Hits ? 11625 Misses ? 1656 Partials ? 509
Can you rebase your PR ?
I think you can incorporate what you pointed too.
I will try to create a PR on you repo for this point
I am ok with that point.
jhlegarreta left a comment
a27b8ac rebased on master and added a few more sections to the guideline based on the link I found.
Some comments inline.
I may find to modify the examples using DIPY's Cython specific code, but the guidelines are already there.
Suggestions, contributions are welcome.