Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Syntax fix example images not rendering #1719

Merged
merged 2 commits into from Jan 13, 2019

Conversation

@kesshijordan
Copy link
Contributor

commented Jan 11, 2019

Images aren't rendering in the website gallery (http://nipy.org/dipy/examples_built/path_length_map.html#example-path-length-map). I think this is because of a syntax error (there's an extra space in the examples_index.rst). I also fixed a random typo I found.

@kesshijordan kesshijordan requested a review from skoudoro Jan 11, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 12, 2019

Codecov Report

Merging #1719 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1719      +/-   ##
==========================================
+ Coverage   84.24%   84.27%   +0.02%     
==========================================
  Files         114      114              
  Lines       13556    13556              
  Branches     2139     2139              
==========================================
+ Hits        11420    11424       +4     
+ Misses       1640     1637       -3     
+ Partials      496      495       -1
Impacted Files Coverage Δ
dipy/reconst/forecast.py 92.22% <0%> (+2.07%) ⬆️
@skoudoro

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

Thank you @kesshijordan, I tested this locally and it looks good, merging

@skoudoro skoudoro merged commit 3b8caea into nipy:master Jan 13, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 260159d...a93049d
Details
codecov/project 84.27% (+0.02%) compared to 260159d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.