Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Python 3 compatibility for some tools script #1738

Merged
merged 5 commits into from Feb 15, 2019

Conversation

@skoudoro
Copy link
Member

commented Feb 12, 2019

This PR is just an update of some useful script because they were only compatible with python 2...

I used the opportunity to fix some pep8.

@arokem

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

I see that you are still retaining Python 2 compatibility. Should we just go ahead and convert this to drop Python 2 support? That way, we can get rid of the six dependency.

@skoudoro

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

sounds good, I am ok with that

@arokem

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

LGTM. If no one else has any issues, I can merge this in a couple of days.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 13, 2019

Codecov Report

Merging #1738 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1738   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files         115      115           
  Lines       13606    13606           
  Branches     2144     2144           
=======================================
  Hits        11465    11465           
  Misses       1643     1643           
  Partials      498      498

@arokem arokem merged commit c3c5217 into nipy:master Feb 15, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 43c8324...08bf785
Details
codecov/project 84.26% remains the same compared to 43c8324
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:fix-tools-py2-to-py3 branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.