Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fixes #1751, by adding a `scale` key-word arg to `decfa` #1753

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@arokem
Copy link
Member

commented Mar 6, 2019

See #1751

@skoudoro
Copy link
Member

left a comment

LGTM, I just wonder whether it will be better to normalize by using min() max() of the original data to be more generic. What do you think?

Otherwise, I will merge it tomorrow if there is no other comment

@arokem

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

I think that could potentially go wrong in data where the maximal number is smaller than 1.0

I think that in that case, you'd want the maximal output to be smaller than 255.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Thanks @arokem, merging

@skoudoro skoudoro merged commit aaeed62 into nipy:master Mar 7, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.